[ISSUE-522] [operator] pass RSS_IP to coordinator container env #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also ping @wangao1236 |
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
============================================
+ Coverage 59.76% 59.78% +0.01%
- Complexity 1768 1769 +1
============================================
Files 205 205
Lines 11531 11531
Branches 1033 1033
============================================
+ Hits 6892 6894 +2
+ Misses 4233 4232 -1
+ Partials 406 405 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wangao1236
approved these changes
Jan 31, 2023
kaijchen
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NODE_NAMEandRSS_IPenv variables are set in coordinator's container.Why are the changes needed?
In a complex K8S env, there might be multiple interfaces/ips in the container env. Uniffle cannot detect which
ip should be used automatically. It's better to specify the correct container ip here.
Also we are passing RSS_IP to shuffle server, coordinator and shuffle server should align this behavior.
This PR fixes #522
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Manually verify