Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #525][operator] refine svc creations #530

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

advancedxy
Copy link
Contributor

@advancedxy advancedxy commented Jan 31, 2023

What changes were proposed in this pull request?

  1. generate headless svc for coordinators and pass this service to shuffle servers
  2. makes RPCNodePort/HTTPNodePort optional for coordinators
  3. remove service creation for shuffle servers.

Why are the changes needed?

This fixes #525

Does this PR introduce any user-facing change?

No

How was this patch tested?

It has already been manually verified, and will add more UTs.

@advancedxy
Copy link
Contributor Author

ping @wangao1236 to see if you have any other input.

@advancedxy advancedxy force-pushed the issue_525 branch 2 times, most recently from 52a22d1 to 33f21b0 Compare February 2, 2023 09:50
@advancedxy advancedxy marked this pull request as ready for review February 2, 2023 09:51
@advancedxy
Copy link
Contributor Author

ping @wangao1236 this should be ready for review.

@advancedxy advancedxy force-pushed the issue_525 branch 2 times, most recently from 6b1512c to 82695a8 Compare February 2, 2023 11:45
@advancedxy
Copy link
Contributor Author

Gently ping @wangao1236.

@advancedxy advancedxy changed the title [ISSUE-525][operator] refine svc creations [ISSUE#525][operator] refine svc creations Feb 6, 2023
@advancedxy advancedxy changed the title [ISSUE#525][operator] refine svc creations [ISSUE#525][operator] #525 refine svc creations Feb 6, 2023
@advancedxy advancedxy changed the title [ISSUE#525][operator] #525 refine svc creations [ISSUE#525][operator] refine svc creations Feb 6, 2023
@advancedxy advancedxy force-pushed the issue_525 branch 3 times, most recently from dede8d6 to e87cc0a Compare February 6, 2023 02:10
@advancedxy advancedxy changed the title [ISSUE#525][operator] refine svc creations [ISSUE #525][operator] refine svc creations Feb 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #530 (8c7ad99) into master (cf9afab) will increase coverage by 1.15%.
The diff coverage is 96.15%.

@@             Coverage Diff              @@
##             master     #530      +/-   ##
============================================
+ Coverage     59.69%   60.85%   +1.15%     
  Complexity     1795     1795              
============================================
  Files           213      213              
  Lines         12414    12372      -42     
  Branches       1050     1050              
============================================
+ Hits           7411     7529     +118     
+ Misses         4594     4435     -159     
+ Partials        409      408       -1     
Impacted Files Coverage Δ
...pkg/controller/sync/shuffleserver/shuffleserver.go 85.78% <0.00%> (+24.55%) ⬆️
...bernetes/operator/pkg/controller/controller/rss.go 35.36% <100.00%> (+0.22%) ⬆️
...tor/pkg/controller/sync/coordinator/coordinator.go 97.87% <100.00%> (+31.89%) ⬆️
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 59.25% <100.00%> (+0.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy advancedxy merged commit 5cba4e7 into apache:master Feb 6, 2023
@advancedxy advancedxy deleted the issue_525 branch February 6, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask][operator] svc generation refinement
4 participants