Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-524][operator] Upgrading rss could also be deleted #531

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

advancedxy
Copy link
Contributor

@advancedxy advancedxy commented Jan 31, 2023

What changes were proposed in this pull request?

  1. soft the constraint that upgrading rss object cannot be deleted

Why are the changes needed?

more flexibility.
This fixes #524

Does this PR introduce any user-facing change?

For RSS cluster admin, they can delete a upgrading rss cluster.

How was this patch tested?

Manually verified and an added UT

@advancedxy
Copy link
Contributor Author

ping @wangao1236

@advancedxy advancedxy marked this pull request as ready for review February 1, 2023 07:36
@advancedxy
Copy link
Contributor Author

@wangao1236 please take a look. This should be ready for merge.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #531 (a7263f1) into master (ebbe2db) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #531      +/-   ##
============================================
+ Coverage     60.21%   60.25%   +0.03%     
  Complexity     1784     1784              
============================================
  Files           205      205              
  Lines         11557    11558       +1     
  Branches       1042     1042              
============================================
+ Hits           6959     6964       +5     
+ Misses         4190     4187       -3     
+ Partials        408      407       -1     
Impacted Files Coverage Δ
...bernetes/operator/pkg/controller/controller/rss.go 33.22% <0.00%> (+0.74%) ⬆️
...y/kubernetes/operator/pkg/webhook/inspector/rss.go 47.70% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy advancedxy merged commit 2b872da into apache:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] [operator] rss operator could delete upgrading RSS cluster
4 participants