Result of mkdirs() is ignored in LocalFileWriteHandler#createBasePath() #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
============================================
+ Coverage 60.23% 60.27% +0.03%
Complexity 1785 1785
============================================
Files 205 205
Lines 11557 11556 -1
Branches 1042 1041 -1
============================================
+ Hits 6961 6965 +4
+ Misses 4189 4185 -4
+ Partials 407 406 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kaijchen
changed the title
advancedxy
reviewed
Feb 1, 2023
storage/src/main/java/org/apache/uniffle/storage/handler/impl/LocalFileWriteHandler.java
Outdated
Show resolved
Hide resolved
zuston
reviewed
Feb 2, 2023
| try { | ||
| Files.createDirectories(Paths.get(basePath)); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to create shuffle folder: " + basePath, e); |
kaijchen
changed the title
advancedxy
approved these changes
Feb 2, 2023
|
Thanks @advancedxy and @zuston for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix error handling in
LocalFileWriteHandler#createBasePath().Throw a
RssExceptionin case of failure.Why are the changes needed?
The return value of
baseFolder.mkdirs()was ignored.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.