[Improvement] Only report to the shuffle servers that owns the blocks #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
============================================
- Coverage 60.25% 59.41% -0.84%
- Complexity 1784 1787 +3
============================================
Files 205 213 +8
Lines 11558 12357 +799
Branches 1042 1045 +3
============================================
+ Hits 6964 7342 +378
- Misses 4187 4606 +419
- Partials 407 409 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xianjingfeng
reviewed
Feb 2, 2023
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Feb 3, 2023
integration-test/common/src/test/java/org/apache/uniffle/test/ShuffleWithRssClientTest.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Feb 3, 2023
| for (Map.Entry<ShuffleServerInfo, List<Integer>> entry : groupedPartitions.entrySet()) { | ||
| Map<Integer, List<Long>> requestBlockIds = Maps.newHashMap(); | ||
| for (Integer partitionId : entry.getValue()) { | ||
| requestBlockIds.put(partitionId, partitionToBlockIds.get(partitionId)); | ||
| List<Long> partitions = partitionToBlockIds.get(partitionId); |
There was a problem hiding this comment.
this should be blockIds instead of parttions.
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java
Show resolved
Hide resolved
xianjingfeng
reviewed
Feb 3, 2023
| groupedPartitions.putIfAbsent(ssi, Lists.newArrayList()); | ||
| } | ||
| groupedPartitions.get(ssi).add(entry.getKey()); | ||
| groupedPartitions.putIfAbsent(ssi, Lists.newArrayList()); |
There was a problem hiding this comment.
Lists.newArrayList() will be invoked everytime.
There was a problem hiding this comment.
Emm.. Yes, I forget this problem for putIfAbsent
There was a problem hiding this comment.
Actually, the original logic is OK for me. Let me recover this part.
advancedxy
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Only report to the shuffle servers that owns the blocks
Why are the changes needed?
I found some unnecessary log is shown in the shuffle server's log, like this
As shown above, there is no necessary to report 0 blocks to shuffle server for client. Let's remove this logic.
Improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?