[operator] fix error kind of ownerreference #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
============================================
+ Coverage 59.20% 59.28% +0.07%
+ Complexity 1786 1785 -1
============================================
Files 213 213
Lines 12358 12357 -1
Branches 1042 1042
============================================
+ Hits 7317 7326 +9
+ Misses 4635 4624 -11
- Partials 406 407 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Feb 2, 2023
|
Hi @wangao1236 ao, could you help also edit the PR summary here to fill the contents:? |
Ok, I'll do it. |
wangao1236
force-pushed
the
fix-error-kind-in-ownerreferences
branch
from
0f5db17
to
3156312
Compare
advancedxy
approved these changes
Feb 2, 2023
|
Thanks @wangao1236, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix #529
Why are the changes needed?
This fix #529.
After this fix, garbage collection in k8s cluster can be completed normally.
Does this PR introduce any user-facing change?
This is a bug fix, after this pr. Child resource created by rss could be gced automatically.
How was this patch tested?
After the rss object is deleted, see if the rss-dependent objects (such as services and statefulsets) are cleaned up with it to verify that the function is normal.