Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpotBugs] Enable SC_START_IN_CTOR check #541

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 2, 2023

What changes were proposed in this pull request?

Remove SC_START_IN_CTOR from spotbugs-exclude.xml.
It was excluded in #517 by mistake.

Why are the changes needed?

#532

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #541 (35e93ea) into master (a45be20) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
- Coverage     59.18%   58.65%   -0.54%     
+ Complexity     1785     1566     -219     
============================================
  Files           213      191      -22     
  Lines         12356    10523    -1833     
  Branches       1042      883     -159     
============================================
- Hits           7313     6172    -1141     
+ Misses         4636     3987     -649     
+ Partials        407      364      -43     
Impacted Files Coverage Δ
...storage/handler/impl/DataSkippableReadHandler.java 83.78% <0.00%> (-2.71%) ⬇️
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
...mapreduce/task/reduce/RssInMemoryRemoteMerger.java
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
...rg/apache/hadoop/mapred/RssMapOutputCollector.java
...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
...g/apache/hadoop/mapred/SortWriteBufferManager.java
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen merged commit e2096d6 into apache:master Feb 2, 2023
@kaijchen kaijchen deleted the sc-start branch February 2, 2023 09:21
@kaijchen
Copy link
Contributor Author

kaijchen commented Feb 2, 2023

Sorry, referenced the wrong issue. Should be #532.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants