-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-546] Replace ResponseStatusCode with StatusCode #547
Conversation
ResponseStatusCode
to StatusCode
.
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
============================================
- Coverage 59.44% 59.32% -0.13%
+ Complexity 1787 1783 -4
============================================
Files 213 213
Lines 12351 12351
Branches 1042 1042
============================================
- Hits 7342 7327 -15
- Misses 4600 4616 +16
+ Partials 409 408 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Let's see if other people have more input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xianjingfeng.
LGTM2 @xianjingfeng. |
Thanks @xianjingfeng for the work. Thanks @advancedxy and @smallzhongfeng for the review. |
What changes were proposed in this pull request?
1.Replace
ResponseStatusCode
withStatusCode
.2.Move
StatusCode
torss-common
Fix #546
Why are the changes needed?
Code quality.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.