Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-546] Replace ResponseStatusCode with StatusCode #547

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

xianjingfeng
Copy link
Member

@xianjingfeng xianjingfeng commented Feb 3, 2023

What changes were proposed in this pull request?

1.Replace ResponseStatusCode with StatusCode.
2.Move StatusCode to rss-common
Fix #546

Why are the changes needed?

Code quality.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen kaijchen changed the title [ISSUE-546] Replace ResponseStatusCode to StatusCode. [ISSUE-546] Replace ResponseStatusCode by StatusCode Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #547 (cc34e45) into master (0ad8a15) will decrease coverage by 0.13%.
The diff coverage is 6.66%.

@@             Coverage Diff              @@
##             master     #547      +/-   ##
============================================
- Coverage     59.44%   59.32%   -0.13%     
+ Complexity     1787     1783       -4     
============================================
  Files           213      213              
  Lines         12351    12351              
  Branches       1042     1042              
============================================
- Hits           7342     7327      -15     
- Misses         4600     4616      +16     
+ Partials        409      408       -1     
Impacted Files Coverage Δ
...java/org/apache/uniffle/common/rpc/StatusCode.java 0.00% <ø> (ø)
...a/org/apache/uniffle/server/RegisterHeartBeat.java 87.71% <ø> (ø)
...pache/uniffle/server/ShuffleServerGrpcService.java 0.80% <ø> (ø)
.../org/apache/uniffle/server/ShuffleTaskManager.java 76.76% <ø> (ø)
...he/uniffle/server/buffer/ShuffleBufferManager.java 83.98% <ø> (ø)
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 34.95% <6.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

advancedxy
advancedxy previously approved these changes Feb 3, 2023
Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's see if other people have more input.

kaijchen
kaijchen previously approved these changes Feb 3, 2023
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xianjingfeng.

@smallzhongfeng
Copy link
Contributor

LGTM2 @xianjingfeng.

@kaijchen kaijchen changed the title [ISSUE-546] Replace ResponseStatusCode by StatusCode [ISSUE-546] Replace ResponseStatusCode with StatusCode Feb 3, 2023
@kaijchen kaijchen merged commit cdce419 into apache:master Feb 3, 2023
@kaijchen
Copy link
Contributor

kaijchen commented Feb 3, 2023

Thanks @xianjingfeng for the work. Thanks @advancedxy and @smallzhongfeng for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Replace ResponseStatusCode to StatusCode.
5 participants