[ISSUE-545][operator] feat: support setting runtime class name and env for rss #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangao1236
changed the title
wangao1236
force-pushed
the
feat-set-runtime-class-name-for-rss
branch
from
de7303f
to
5353bcd
Compare
advancedxy
reviewed
Feb 3, 2023
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
Show resolved
Hide resolved
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Outdated
Show resolved
Hide resolved
wangao1236
force-pushed
the
feat-set-runtime-class-name-for-rss
branch
from
5353bcd
to
01caabd
Compare
kaijchen
changed the title
kaijchen
changed the title
advancedxy
changed the title
|
Merged, thanks @wangao1236 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support setting custom runtime class name and env for rss objects.
Why are the changes needed?
More flexibility.
Fix issue #545.
Does this PR introduce any user-facing change?
For RSS cluster admin, they can set custom runtime class name and env of pods.
How was this patch tested?
Manually verified and an added UT.