Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Cleanup "throws RuntimeException" #549

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 3, 2023

What changes were proposed in this pull request?

Remove "throws RuntimeException" from method signature.

Why are the changes needed?

There is no need to declare "throws RuntimeException".

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #549 (9f7cee2) into master (3a63386) will increase coverage by 0.66%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #549      +/-   ##
============================================
+ Coverage     59.44%   60.10%   +0.66%     
+ Complexity     1787     1655     -132     
============================================
  Files           213      200      -13     
  Lines         12351    11075    -1276     
  Branches       1042      920     -122     
============================================
- Hits           7342     6657     -685     
+ Misses         4600     4039     -561     
+ Partials        409      379      -30     
Impacted Files Coverage Δ
...org/apache/spark/shuffle/RssSparkShuffleUtils.java 69.38% <ø> (ø)
.../java/org/apache/uniffle/common/util/RssUtils.java 58.45% <ø> (ø)
.../org/apache/uniffle/coordinator/AccessManager.java 94.28% <ø> (ø)
...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java
.../hadoop/mapreduce/task/reduce/RssBypassWriter.java
...rg/apache/hadoop/mapred/RssMapOutputCollector.java
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java
...pache/hadoop/mapreduce/task/reduce/RssFetcher.java
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen merged commit 07aaeb2 into apache:master Feb 3, 2023
@kaijchen kaijchen deleted the cleanup-throws-runtime-exception branch February 3, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants