Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#554] feat: infer rss base storage conf from env #555

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

advancedxy
Copy link
Contributor

What changes were proposed in this pull request?

new method getConfiguredLocalDirs is added to retrieve rss base storage path from env first

Why are the changes needed?

Fixes #554

Does this PR introduce any user-facing change?

RSS admin may specify rss base path for shuffle server when deploying

How was this patch tested?

Added UT.

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #555 (8b62edc) into master (ebbe2db) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
+ Coverage     60.21%   60.52%   +0.30%     
+ Complexity     1784     1570     -214     
============================================
  Files           205      191      -14     
  Lines         11557    10532    -1025     
  Branches       1042      886     -156     
============================================
- Hits           6959     6374     -585     
+ Misses         4190     3793     -397     
+ Partials        408      365      -43     
Impacted Files Coverage Δ
...java/org/apache/uniffle/common/config/RssConf.java 32.41% <100.00%> (+0.46%) ⬆️
.../java/org/apache/uniffle/common/util/RssUtils.java 59.31% <100.00%> (+0.85%) ⬆️
...org/apache/uniffle/server/LocalStorageChecker.java 70.19% <100.00%> (ø)
...org/apache/uniffle/server/ShuffleFlushManager.java 84.37% <100.00%> (ø)
...he/uniffle/server/storage/LocalStorageManager.java 85.87% <100.00%> (ø)
...storage/handler/impl/DataSkippableReadHandler.java 83.78% <0.00%> (-2.71%) ⬇️
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 34.44% <0.00%> (-0.51%) ⬇️
...a/org/apache/uniffle/common/ShuffleServerInfo.java 75.00% <0.00%> (ø)
... and 43 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy advancedxy changed the title [#554] infer rss base storage conf from env [#554] feat: infer rss base storage conf from env Feb 7, 2023
@advancedxy
Copy link
Contributor Author

gently ping @kaijchen

Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@advancedxy advancedxy merged commit a4e56d3 into apache:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] rss storage base path could be inferred from env
4 participants