Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Followup #249] refactor: cleanup code and unify interfaces #558

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 7, 2023

What changes were proposed in this pull request?

Followup #249. Cleanup code and unify interfaces.

Why are the changes needed?

Cleanup code and unify interfaces.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@kaijchen kaijchen requested a review from zuston February 7, 2023 09:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #558 (7e71582) into master (5cba4e7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
- Coverage     60.87%   60.86%   -0.01%     
+ Complexity     1796     1793       -3     
============================================
  Files           213      213              
  Lines         12372    12371       -1     
  Branches       1050     1049       -1     
============================================
- Hits           7531     7530       -1     
  Misses         4434     4434              
  Partials        407      407              
Impacted Files Coverage Δ
...org/apache/uniffle/server/ShuffleFlushManager.java 84.45% <100.00%> (+0.08%) ⬆️
.../org/apache/uniffle/server/ShuffleTaskManager.java 76.62% <100.00%> (-0.14%) ⬇️
...he/uniffle/server/buffer/ShuffleBufferManager.java 83.98% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen changed the title [Followup #249] Cleanup code and unify interfaces [Followup #249] refactor: cleanup code and unify interfaces Feb 8, 2023
@kaijchen kaijchen merged commit 24ea73c into apache:master Feb 8, 2023
@kaijchen
Copy link
Contributor Author

kaijchen commented Feb 8, 2023

Thanks @advancedxy for the review.

@kaijchen kaijchen deleted the followup-249 branch February 8, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants