[#559] test: use withEnvironmentVariable to replace RssUtilsTest#setEnv #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
force-pushed
the
issue_559
branch
2 times, most recently
from
262b7bb
to
10c0793
Compare
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
============================================
- Coverage 60.87% 60.50% -0.37%
+ Complexity 1796 1567 -229
============================================
Files 213 191 -22
Lines 12372 10528 -1844
Branches 1050 886 -164
============================================
- Hits 7531 6370 -1161
+ Misses 4434 3793 -641
+ Partials 407 365 -42 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kaijchen
reviewed
Feb 7, 2023
There was a problem hiding this comment.
Thanks @advancedxy for the work. Some general questions here.
common/src/test/java/org/apache/uniffle/common/util/RssUtilsTest.java
Outdated
Show resolved
Hide resolved
storage/src/test/java/org/apache/uniffle/storage/EnvTestBase.java
Outdated
Show resolved
Hide resolved
kaijchen
reviewed
Feb 7, 2023
server/src/test/java/org/apache/uniffle/server/ShuffleServerConfTest.java
Outdated
Show resolved
Hide resolved
advancedxy
changed the title
kaijchen
approved these changes
Feb 8, 2023
kaijchen
changed the title
|
Merged, thanks @kaijchen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
replace
RssUtils.setEnvbywithEnvironmentVariableWhy are the changes needed?
Better code quality. This fixes #559
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existed UTs.