Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#545][FOLLOWUP] update rbac rule for webhook #566

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

advancedxy
Copy link
Contributor

What changes were proposed in this pull request?

Add runtime class name get/list permission for webhook

Why are the changes needed?

webhook needs this permission to validate runtime class name

Does this PR introduce any user-facing change?

Yes. After this, users can specify runtimeClassName

How was this patch tested?

Verified manually.

wangao1236
wangao1236 previously approved these changes Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #566 (1f3df7b) into master (f461460) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #566      +/-   ##
============================================
- Coverage     60.87%   60.47%   -0.40%     
+ Complexity     1796     1568     -228     
============================================
  Files           213      191      -22     
  Lines         12375    10531    -1844     
  Branches       1049      885     -164     
============================================
- Hits           7533     6369    -1164     
+ Misses         4435     3797     -638     
+ Partials        407      365      -42     
Impacted Files Coverage Δ
.../java/org/apache/uniffle/server/ShuffleServer.java 60.95% <0.00%> (-3.43%) ⬇️
...ava/org/apache/uniffle/server/ShuffleTaskInfo.java 98.07% <0.00%> (-1.93%) ⬇️
.../apache/uniffle/coordinator/ClientConfManager.java 91.54% <0.00%> (-1.41%) ⬇️
.../hadoop/mapreduce/task/reduce/RssEventFetcher.java
...org/apache/spark/shuffle/RssSparkShuffleUtils.java
.../java/org/apache/spark/shuffle/RssSparkConfig.java
...preduce/task/reduce/RssRemoteMergeManagerImpl.java
...che/spark/shuffle/writer/BufferManagerOptions.java
...ava/org/apache/spark/shuffle/RssShuffleHandle.java
...java/org/apache/hadoop/mapred/SortWriteBuffer.java
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangao1236
Copy link
Collaborator

LGTM

@advancedxy advancedxy requested a review from jerqi February 9, 2023 06:54
@advancedxy advancedxy merged commit d0f57ef into apache:master Feb 9, 2023
@advancedxy advancedxy deleted the issue_545_followup branch February 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants