Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] docs: correct the format of server_guide doc #608

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Feb 16, 2023

What changes were proposed in this pull request?

correct the format of server_guide doc

Why are the changes needed?

The markdown format is wrong in original shuffle server guide doc

Does this PR introduce any user-facing change?

No

How was this patch tested?

Dont need

@zuston zuston requested a review from kaijchen February 16, 2023 04:26
@zuston
Copy link
Member Author

zuston commented Feb 16, 2023

I hope this could be included in version 0.7. PTAL @kaijchen

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #608 (a4e7f39) into master (80c12a7) will increase coverage by 2.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
+ Coverage     60.85%   63.15%   +2.29%     
- Complexity     1800     1801       +1     
============================================
  Files           214      200      -14     
  Lines         12387    10416    -1971     
  Branches       1044     1044              
============================================
- Hits           7538     6578     -960     
+ Misses         4444     3494     -950     
+ Partials        405      344      -61     
Impacted Files Coverage Δ
...y/kubernetes/operator/pkg/webhook/inspector/pod.go
deploy/kubernetes/operator/pkg/utils/config.go
deploy/kubernetes/operator/pkg/utils/rss.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
deploy/kubernetes/operator/pkg/utils/certs.go
...eploy/kubernetes/operator/pkg/utils/coordinator.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
...oy/kubernetes/operator/pkg/controller/util/util.go
...bernetes/operator/pkg/controller/controller/rss.go
...y/kubernetes/operator/pkg/webhook/inspector/rss.go
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kaijchen kaijchen changed the title [MINOR] chore(doc): correct the format of server_guide doc [MINOR] docs: correct the format of server_guide doc Feb 16, 2023
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston.

@kaijchen kaijchen merged commit 7f9b561 into apache:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants