[#613] test: SimpleClusterManagerTest#updateExcludeNodesTest #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
=========================================
Coverage 60.85% 60.85%
Complexity 1800 1800
=========================================
Files 214 214
Lines 12387 12387
Branches 1044 1044
=========================================
Hits 7538 7538
Misses 4444 4444
Partials 405 405 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
approved these changes
Feb 16, 2023
xianjingfeng
added a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…pache#614) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md 2. Ensure you have added or run the appropriate tests for your PR 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> Fix flaky test SimpleClusterManagerTest#updateExcludeNodesTest ### Why are the changes needed? <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> Flaky test. If `updateNodesInterval` = 2000, the first scheduling time is 4 seconds later. https://github.com/apache/incubator-uniffle/blob/7f9b5615162bd013426ab6d58f5054fa1cf68d0c/coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java#L96-L97 ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master. If no, write 'No'. --> No ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> No need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix flaky test SimpleClusterManagerTest#updateExcludeNodesTest
Why are the changes needed?
Flaky test.
If
updateNodesInterval= 2000, the first scheduling time is 4 seconds later.incubator-uniffle/coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java
Lines 96 to 97 in 7f9b561
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need