Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#545][FOLLOWUP]feat(operator): support specifying custom affinity & tolerations #641

Merged
merged 7 commits into from
Feb 22, 2023

Conversation

crain-cn
Copy link
Contributor

@crain-cn crain-cn commented Feb 22, 2023

What changes were proposed in this pull request?

Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec.

Why are the changes needed?

  1. Production environment deployment needs to use.
  2. In order to change parameters flexibly.

This is a followup of #545

Does this PR introduce any user-facing change?

For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators.

How was this patch tested?

Manually verified.

image

@crain-cn crain-cn changed the title feat(operator): support specifying custom affinity [#545]feat(operator): support specifying custom affinity Feb 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #641 (aa08b98) into master (c45c187) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #641      +/-   ##
============================================
- Coverage     60.89%   60.63%   -0.26%     
- Complexity     1798     1799       +1     
============================================
  Files           214      216       +2     
  Lines         12381    12455      +74     
  Branches       1042     1052      +10     
============================================
+ Hits           7539     7552      +13     
- Misses         4438     4496      +58     
- Partials        404      407       +3     
Impacted Files Coverage Δ
...tor/pkg/controller/sync/coordinator/coordinator.go 97.84% <100.00%> (-0.04%) ⬇️
...pkg/controller/sync/shuffleserver/shuffleserver.go 85.56% <100.00%> (-0.22%) ⬇️
...a/org/apache/uniffle/server/RegisterHeartBeat.java 43.85% <0.00%> (-43.86%) ⬇️
.../java/org/apache/uniffle/server/ShuffleServer.java 62.06% <0.00%> (-2.32%) ⬇️
...he/uniffle/server/buffer/ShuffleBufferManager.java 82.74% <0.00%> (-0.36%) ⬇️
.../java/org/apache/uniffle/common/util/RssUtils.java 59.31% <0.00%> (ø)
.../org/apache/uniffle/common/config/ConfigUtils.java 95.55% <0.00%> (ø)
...rg/apache/uniffle/common/config/ConfigOptions.java 96.61% <0.00%> (ø)
...n/java/org/apache/uniffle/common/ServerStatus.java 0.00% <0.00%> (ø)
...ffle/common/exception/InvalidRequestException.java 0.00% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@crain-cn crain-cn changed the title [#545]feat(operator): support specifying custom affinity [#545]feat(operator): support specifying custom affinity & tolerations Feb 22, 2023
@crain-cn
Copy link
Contributor Author

@advancedxy @jerqi
I closed #638 , do you want to submit this pr?

@advancedxy advancedxy changed the title [#545]feat(operator): support specifying custom affinity & tolerations [#545][FOLLOWUP]feat(operator): support specifying custom affinity & tolerations Feb 22, 2023
@advancedxy
Copy link
Contributor

@crain-cn thanks. The code LGTM overall, except one minor comment.

@crain-cn
Copy link
Contributor Author

@crain-cn thanks. The code LGTM overall, except one minor comment.

Thanks.

@crain-cn
Copy link
Contributor Author

crain-cn commented Feb 22, 2023

@crain-cn thanks. The code LGTM overall, except one minor comment.

Thanks. I have finished dealing with the comments. Could the @advancedxy please take a look?

@advancedxy advancedxy merged commit b3a10d3 into apache:master Feb 22, 2023
@advancedxy
Copy link
Contributor

Merged this. Thanks @crain-cn

@crain-cn crain-cn deleted the featrue/Support-affinity branch February 22, 2023 11:26
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
…ity & tolerations (apache#641)

### What changes were proposed in this pull request?
Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec.  

### Why are the changes needed?
1. Production environment deployment needs to use.
2. In order to provider flexible scheduling semantics

This is a followup of apache#545 

### Does this PR introduce _any_ user-facing change?
For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators.

### How was this patch tested?
Added UTs and manually verified.

![image](https://user-images.githubusercontent.com/45311215/220524164-4d21758a-9f5e-4285-b455-2546058fe359.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants