-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#545][FOLLOWUP]feat(operator): support specifying custom affinity & tolerations #641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
============================================
- Coverage 60.89% 60.63% -0.26%
- Complexity 1798 1799 +1
============================================
Files 214 216 +2
Lines 12381 12455 +74
Branches 1042 1052 +10
============================================
+ Hits 7539 7552 +13
- Misses 4438 4496 +58
- Partials 404 407 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@advancedxy @jerqi |
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Outdated
Show resolved
Hide resolved
@crain-cn thanks. The code LGTM overall, except one minor comment. |
delete Tolerations default.
Thanks. |
Thanks. I have finished dealing with the comments. Could the @advancedxy please take a look? |
Merged this. Thanks @crain-cn |
…ity & tolerations (apache#641) ### What changes were proposed in this pull request? Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec. ### Why are the changes needed? 1. Production environment deployment needs to use. 2. In order to provider flexible scheduling semantics This is a followup of apache#545 ### Does this PR introduce _any_ user-facing change? For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators. ### How was this patch tested? Added UTs and manually verified. ![image](https://user-images.githubusercontent.com/45311215/220524164-4d21758a-9f5e-4285-b455-2546058fe359.png)
What changes were proposed in this pull request?
Support specifying coordinator/shuffler server's affinity and tolerations fields for RSS spec.
Why are the changes needed?
This is a followup of #545
Does this PR introduce any user-facing change?
For RSS cluster admin, they can set custom affinity for shuffle servers and coordinators.
How was this patch tested?
Manually verified.