[#635] feat(client): enable LOCAL_ORDER by default for Spark AQE #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @jerqi |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
============================================
+ Coverage 60.61% 62.91% +2.29%
- Complexity 1798 1800 +2
============================================
Files 216 202 -14
Lines 12462 10491 -1971
Branches 1052 1052
============================================
- Hits 7554 6600 -954
+ Misses 4500 3545 -955
+ Partials 408 346 -62 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Feb 22, 2023
common/src/main/java/org/apache/uniffle/common/config/RssClientConf.java
Outdated
Show resolved
Hide resolved
zuston
commented
Feb 22, 2023
| @VisibleForTesting | ||
| protected static ShuffleDataDistributionType getDataDistributionType(SparkConf sparkConf) { | ||
| RssConf rssConf = RssSparkConfig.toRssConf(sparkConf); | ||
| if ((boolean) sparkConf.get(SQLConf.ADAPTIVE_EXECUTION_ENABLED()) |
There was a problem hiding this comment.
sparkConf.get(SQLConf.ADAPTIVE_EXECUTION_ENABLED() should be used to be consistent with spark, because different spark versions have different default value
There was a problem hiding this comment.
is (boolean) necessary?
|
thanks @zuston , merged to master. |
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
apache#644) ### What changes were proposed in this pull request? enable LOCAL_ORDER by default for Spark AQE ### Why are the changes needed? Currently, the local_order data distribution type should be activated explicitly. It's better to enable it when using AQE by default. Fix: apache#635 ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? 1. Existing UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
enable LOCAL_ORDER by default for Spark AQE
Why are the changes needed?
Currently, the local_order data distribution type should be activated explicitly. It's better to enable it when using AQE by default.
Fix: #635
Does this PR introduce any user-facing change?
Yes
How was this patch tested?