Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#576] test: increase timeout and remove initialization time in storage strategy tests #646

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

1、Increase the method execution timeout
2、Don't need to sleep for 2s to initialize, because we have manually closed the detectStorageScheduler

Why are the changes needed?

Fix: #576

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Fix uts.

@smallzhongfeng
Copy link
Contributor Author

PTAL @kaijchen Thanks~

@kaijchen kaijchen changed the title [ISSUE-576] Increase the timeout and remove the initialization time [#576] test: increase the timeout and remove the initialization time Feb 22, 2023
Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smallzhongfeng.

@kaijchen kaijchen changed the title [#576] test: increase the timeout and remove the initialization time [#576] test: increase timeout and remove initialization time in storage strategy tests Feb 22, 2023
@jerqi
Copy link
Contributor

jerqi commented Feb 23, 2023

thanks @kaijchen @smallzhongfeng , merged to master & branch-0.7. cc@zuston

@jerqi jerqi merged commit 0a103e0 into apache:master Feb 23, 2023
jerqi pushed a commit that referenced this pull request Feb 23, 2023
…646)

### What changes were proposed in this pull request?
1、Increase the method execution timeout
2、Don't need to sleep for 2s to initialize, because we have manually closed the `detectStorageScheduler`

### Why are the changes needed?

Fix: #576

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?

Fix uts.
@smallzhongfeng
Copy link
Contributor Author

Thanks all. :-) @jerqi @kaijchen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: AppBalanceSelectStorageStrategyTest#storageCounterMulThreadTest
3 participants