Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#659] fix(server): fix NPE of ShuffleDataFlushEvent's underStorage in some cases #660

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Feb 25, 2023

What changes were proposed in this pull request?

fix NPE of ShuffleDataFlushEvent's underStorage in some cases

Why are the changes needed?

Fix: #659

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs

@zuston zuston requested a review from jerqi February 25, 2023 02:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #660 (f760334) into master (18c738e) will increase coverage by 2.28%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #660      +/-   ##
============================================
+ Coverage     60.60%   62.89%   +2.28%     
- Complexity     1799     1801       +2     
============================================
  Files           216      202      -14     
  Lines         12458    10494    -1964     
  Branches       1052     1052              
============================================
- Hits           7550     6600     -950     
+ Misses         4500     3547     -953     
+ Partials        408      347      -61     
Impacted Files Coverage Δ
...g/apache/uniffle/server/ShuffleDataFlushEvent.java 83.67% <100.00%> (ø)
...bernetes/operator/pkg/controller/controller/rss.go
...oy/kubernetes/operator/pkg/controller/util/util.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
deploy/kubernetes/operator/pkg/utils/certs.go
...pkg/controller/sync/shuffleserver/shuffleserver.go
...y/kubernetes/operator/pkg/webhook/inspector/rss.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
deploy/kubernetes/operator/pkg/utils/config.go
deploy/kubernetes/operator/pkg/utils/util.go
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @advancedxy @zuston ,merged to master & 0.7

@jerqi jerqi merged commit c70d154 into apache:master Feb 25, 2023
jerqi pushed a commit that referenced this pull request Feb 25, 2023
…n some cases (#660)

### What changes were proposed in this pull request?

fix NPE of ShuffleDataFlushEvent's underStorage in some cases

### Why are the changes needed?

Fix: #659

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] NPE of underStorage in ShuffleDataFlushEvent#toString
4 participants