[#678] improvement: Write hdfs files asynchronously when detectStorage
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
============================================
+ Coverage 60.79% 63.04% +2.24%
- Complexity 1839 1840 +1
============================================
Files 221 207 -14
Lines 12655 10677 -1978
Branches 1069 1064 -5
============================================
- Hits 7694 6731 -963
+ Misses 4553 3600 -953
+ Partials 408 346 -62 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
We should avoid multple threads operate the same file. |
It is the same file, but it is written to a different path. |
added 2 commits
March 3, 2023 18:06
|
Maybe we should use CountdownLaunch + (parallelStream or thread pool). |
added 2 commits
March 3, 2023 22:41
|
This doesn't seem to be caused by this pr. |
Same problem as #667 . |
xianjingfeng
reviewed
Mar 4, 2023
...in/java/org/apache/uniffle/coordinator/strategy/storage/AppBalanceSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Mar 4, 2023
...org/apache/uniffle/coordinator/strategy/storage/LowestIOSampleCostSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Mar 4, 2023
...main/java/org/apache/uniffle/coordinator/strategy/storage/AbstractSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Mar 4, 2023
...main/java/org/apache/uniffle/coordinator/strategy/storage/AbstractSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
xianjingfeng
reviewed
Mar 4, 2023
...main/java/org/apache/uniffle/coordinator/strategy/storage/AbstractSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
added 4 commits
March 4, 2023 20:22
xianjingfeng
reviewed
Mar 5, 2023
...in/java/org/apache/uniffle/coordinator/strategy/storage/AppBalanceSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
added 4 commits
March 5, 2023 12:34
advancedxy
reviewed
Mar 5, 2023
...main/java/org/apache/uniffle/coordinator/strategy/storage/AbstractSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/apache/uniffle/coordinator/strategy/storage/SelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/uniffle/coordinator/strategy/storage/AbstractSelectStorageStrategy.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Mar 6, 2023
| @@ -90,6 +91,7 @@ public void selectStorageTest() throws Exception { | |||
| assertEquals(0, applicationManager.getRemoteStoragePathRankValue().get(remoteStorage2).getAppNum().get()); | |||
|
|
|||
| // compare with two remote path | |||
| final Configuration configuration = new Configuration(); | |||
There was a problem hiding this comment.
Seems this line is not needed anymore?
I didn't see the var configuration is used in this method anywhere.
| * Different strategies will have different sorting methods of remote paths | ||
| * @return A comparator is to calculate the RankValue | ||
| */ | ||
| abstract Comparator<Map.Entry<String, RankValue>> getComparator(); |
There was a problem hiding this comment.
Let's make this method as
protected Comparator<Map.Entry<String, RankValue>> getComparator() {
return null;
}
? So AppBalanceSelectorStorageStrategy doesn't need to override this.
added 2 commits
March 6, 2023 16:24
advancedxy
approved these changes
Mar 6, 2023
|
Thanks all! @advancedxy @xianjingfeng @jerqi |
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…tStorage` (apache#680) ### What changes were proposed in this pull request? Write files to hdfs asynchronously and reduce the time of detectStorage ### Why are the changes needed? Fix: apache#678 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Origin uts.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…tStorage` (apache#680) ### What changes were proposed in this pull request? Write files to hdfs asynchronously and reduce the time of detectStorage ### Why are the changes needed? Fix: apache#678 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Origin uts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Write files to hdfs asynchronously and reduce the time of detectStorage
Why are the changes needed?
Fix: #678
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Origin uts.