-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#674] feat(docker): use JDK11 as the default java version in Dockerfile #683
Conversation
PTAL @advancedxy |
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=========================================
Coverage 60.79% 60.79%
Complexity 1839 1839
=========================================
Files 221 221
Lines 12655 12655
Branches 1069 1069
=========================================
Hits 7694 7694
Misses 4553 4553
Partials 408 408 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Does it help when the java version in |
GC is part of java runtime, it shouldn't matter whether the code is compiled with Java 1.8 or Java 11. |
Could you help review again? JDK11 has been applied in our production env, it works well with hadoop3.1.1 @advancedxy |
If it could work well with hadoop client. I think this is a good start. Would you mind create an umbrella issue to tracking all the issues needed to promote using JDK 11 here?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself LGTM.
However would you mind to modify the RP title to reflect the actual change, since it only changes the dockerfile
Also, would you mind to provide a bit more information about how it is tested.
Done.
Yes, more detailed info will be exposed in #674 |
Yes |
…ockerfile (apache#683) ### What changes were proposed in this pull request? Use JDK11 as the default java version in Dockerfile when deploying shuffle servers on K8s. ### Why are the changes needed? As the GC problems mentioned in apache#674, I upgraded the JVM version from JDK8 to JDK11 for shuffle server. And after benchmark, I found the effect of the upgrade is remarkable. And it also works well with Hadoop3.1.1 Based on above practice, it's better to use JDK11 as the default java version to improve stability ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Have tested in production env. Co-authored-by: zhangjunfan <zhangjunfan@qiyi.com>
…ockerfile (apache#683) ### What changes were proposed in this pull request? Use JDK11 as the default java version in Dockerfile when deploying shuffle servers on K8s. ### Why are the changes needed? As the GC problems mentioned in apache#674, I upgraded the JVM version from JDK8 to JDK11 for shuffle server. And after benchmark, I found the effect of the upgrade is remarkable. And it also works well with Hadoop3.1.1 Based on above practice, it's better to use JDK11 as the default java version to improve stability ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? Have tested in production env. Co-authored-by: zhangjunfan <zhangjunfan@qiyi.com>
What changes were proposed in this pull request?
Use JDK11 as the default java version in Dockerfile when deploying shuffle servers on K8s.
Why are the changes needed?
As the GC problems mentioned in #674, I upgraded the JVM version from JDK8 to JDK11 for shuffle server. And after benchmark, I found the effect of the upgrade is remarkable. And it also works well with Hadoop3.1.1
Based on above practice, it's better to use JDK11 as the default java version to improve stability
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Have tested in production env.