Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#397] docs: add the usage of AccessQuotaChecker #692

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

Add the usage of AccessQuotaChecker

Why are the changes needed?

Fix: #397

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #692 (9a86df5) into master (ffa50b9) will increase coverage by 2.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #692      +/-   ##
============================================
+ Coverage     60.80%   63.03%   +2.23%     
  Complexity     1840     1840              
============================================
  Files           221      207      -14     
  Lines         12648    10684    -1964     
  Branches       1062     1062              
============================================
- Hits           7690     6735     -955     
+ Misses         4552     3603     -949     
+ Partials        406      346      -60     
Impacted Files Coverage Δ
deploy/kubernetes/operator/pkg/utils/config.go
...y/kubernetes/operator/pkg/webhook/inspector/pod.go
...oy/kubernetes/operator/pkg/controller/util/util.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
...tor/pkg/controller/sync/coordinator/coordinator.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
...y/kubernetes/operator/pkg/webhook/inspector/rss.go
...pkg/controller/sync/shuffleserver/shuffleserver.go
...bernetes/operator/pkg/controller/controller/rss.go
deploy/kubernetes/operator/pkg/utils/rss.go
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 8f1dd1f into apache:master Mar 8, 2023
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this pull request Mar 21, 2023
### What changes were proposed in this pull request?
Add the usage of `AccessQuotaChecker`

### Why are the changes needed?
Fix: apache#397

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?
Add the usage of `AccessQuotaChecker`

### Why are the changes needed?
Fix: apache#397

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add more usage examples of quota
3 participants