[MINOR] improvement: Reduce the size of Spark patch #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
============================================
+ Coverage 60.80% 63.06% +2.26%
- Complexity 1840 1841 +1
============================================
Files 221 207 -14
Lines 12648 10683 -1965
Branches 1062 1062
============================================
- Hits 7690 6737 -953
+ Misses 4552 3601 -951
+ Partials 406 345 -61 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xianjingfeng
reviewed
Mar 9, 2023
| @@ -188,6 +188,8 @@ public RssShuffleManager(SparkConf sparkConf, boolean isDriver) { | |||
| // External shuffle service is not supported when using remote shuffle service | |||
| sparkConf.set("spark.shuffle.service.enabled", "false"); | |||
| LOG.info("Disable external shuffle service in RssShuffleManager."); | |||
| sparkConf.set("spark.shuffle.reduceLocality.enabled", "false"); | |||
There was a problem hiding this comment.
Because our data is in the RSS cluster or HDFS, locatity is useless for us. If rack aware need this feature, we can turn on this feature when we use rack aware.
There was a problem hiding this comment.
+1. The locality awareness could be supported in the future.
advancedxy
approved these changes
Mar 9, 2023
advancedxy
reviewed
Mar 9, 2023
| @@ -188,6 +188,8 @@ public RssShuffleManager(SparkConf sparkConf, boolean isDriver) { | |||
| // External shuffle service is not supported when using remote shuffle service | |||
| sparkConf.set("spark.shuffle.service.enabled", "false"); | |||
| LOG.info("Disable external shuffle service in RssShuffleManager."); | |||
| sparkConf.set("spark.shuffle.reduceLocality.enabled", "false"); | |||
There was a problem hiding this comment.
Would you mind add a comment here, like L188.
advancedxy
reviewed
Mar 9, 2023
| @@ -205,6 +205,8 @@ public RssShuffleManager(SparkConf conf, boolean isDriver) { | |||
| LOG.info("Disable external shuffle service in RssShuffleManager."); | |||
| sparkConf.set("spark.sql.adaptive.localShuffleReader.enabled", "false"); | |||
| LOG.info("Disable local shuffle reader in RssShuffleManager."); | |||
| sparkConf.set("spark.shuffle.reduceLocality.enabled", "false"); | |||
advancedxy
previously approved these changes
Mar 9, 2023
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
### What changes were proposed in this pull request? As apache/spark#40307 (comment), we could use `spark.shuffle.reduceLocality.enabled` to reduce the modification of the Apache Spark. ### Why are the changes needed? Reduce the spark patch size ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need Co-authored-by: roryqi <roryqi@tencent.com>
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
### What changes were proposed in this pull request? As apache/spark#40307 (comment), we could use `spark.shuffle.reduceLocality.enabled` to reduce the modification of the Apache Spark. ### Why are the changes needed? Reduce the spark patch size ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need Co-authored-by: roryqi <roryqi@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As apache/spark#40307 (comment), we could use
spark.shuffle.reduceLocality.enabledto reduce the modification of the Apache Spark.Why are the changes needed?
Reduce the spark patch size
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need