Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused log info #700

Merged
merged 1 commit into from
Mar 9, 2023
Merged

chore: remove unused log info #700

merged 1 commit into from
Mar 9, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Mar 9, 2023

What changes were proposed in this pull request?

chore: remove unused log info

Why are the changes needed?

chore: remove unused log info

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Don't need

@zuston zuston requested review from advancedxy and jerqi March 9, 2023 03:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #700 (7d54874) into master (00454c1) will increase coverage by 2.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #700      +/-   ##
============================================
+ Coverage     60.80%   63.03%   +2.23%     
  Complexity     1840     1840              
============================================
  Files           221      207      -14     
  Lines         12648    10683    -1965     
  Branches       1062     1062              
============================================
- Hits           7690     6734     -956     
+ Misses         4552     3603     -949     
+ Partials        406      346      -60     
Impacted Files Coverage Δ
...g/apache/uniffle/common/compression/ZstdCodec.java 70.58% <ø> (-1.64%) ⬇️
deploy/kubernetes/operator/pkg/utils/config.go
...oy/kubernetes/operator/pkg/controller/util/util.go
...eploy/kubernetes/operator/pkg/utils/coordinator.go
...tor/pkg/controller/sync/coordinator/coordinator.go
...y/kubernetes/operator/pkg/webhook/inspector/rss.go
...bernetes/operator/pkg/controller/controller/rss.go
...oy/kubernetes/operator/pkg/utils/shufflerserver.go
deploy/kubernetes/operator/pkg/utils/util.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@smallzhongfeng smallzhongfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the GA failure cause by CoordinatorMetricsTest, could you rebase the latest code and trigger again ?

@zuston zuston merged commit a7523bf into apache:master Mar 9, 2023
@zuston zuston deleted the choreLog branch March 9, 2023 07:25
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this pull request Mar 21, 2023
### What changes were proposed in this pull request?
chore: remove unused log info

### Why are the changes needed?
chore: remove unused log info

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Don't need
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?
chore: remove unused log info

### Why are the changes needed?
chore: remove unused log info

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Don't need
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants