[MINOR] Removed unused methods and variable

[smallzhongfeng]

What changes were proposed in this pull request?

1、removed unused methods and variable.
2、modify the return type of some methods

Why are the changes needed?

Clean up code.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Origin uts.

[codecov-commenter]

Codecov Report

Merging #702 (3ed0d01) into master (af21f0d) will increase coverage by 0.12%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master     #702      +/-   ##
============================================
+ Coverage     63.08%   63.20%   +0.12%     
+ Complexity     1842     1839       -3     
============================================
  Files           207      207              
  Lines         10683    10641      -42     
  Branches       1062     1057       -5     
============================================
- Hits           6739     6726      -13     
+ Misses         3600     3570      -30     
- Partials        344      345       +1     

Impacted Files	Coverage Δ
...pache/uniffle/storage/common/LocalStorageMeta.java	84.69% <66.66%> (+10.40%)	⬆️
...he/uniffle/server/storage/LocalStorageManager.java	85.96% <100.00%> (-1.75%)	⬇️
...rg/apache/uniffle/storage/common/LocalStorage.java	60.76% <100.00%> (+5.35%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jerqi]

Could you take a look at the flaky test?
https://github.com/apache/incubator-uniffle/actions/runs/4373629552/jobs/7652043074
I see the logs in this test case.

But I don't see similar logs when I run them in my local machine.

[smallzhongfeng]

Could you take a look at the flaky test? https://github.com/apache/incubator-uniffle/actions/runs/4373629552/jobs/7652043074 I see the logs in this test case.

But I don't see similar logs when I run them in my local machine.

Because we removed the hdfs-minimcluster, the paths of path1 and path2 were not created, and this error was thrown. But I do not affect the logic of their choice of path, because the strategy of IO_SAMPLE compares the time of reading and writing hdfs files. Because the creation of hdfs paths fails, the number of apps written in each path will be compared, and the logic of path selection will not be affected. This GA error should not be the cause of the failure.

[jerqi]

Could you take a look at the flaky test? https://github.com/apache/incubator-uniffle/actions/runs/4373629552/jobs/7652043074 I see the logs in this test case.
But I don't see similar logs when I run them in my local machine.

Because we removed the hdfs-minimcluster, the paths of path1 and path2 were not created, and this error was thrown. But I do not affect the logic of their choice of path, because the strategy of IO_SAMPLE compares the time of reading and writing hdfs files. Because the creation of hdfs paths fails, the number of apps written in each path will be compared, and the logic of path selection will not be affected. This GA error should not be the cause of the failure.

The test case is so flaky ...

[smallzhongfeng]

Yes, if you suspect it is the problem here, I can put forward a new pr, specify a path in this test class to avoid throwing the exception in the screenshot above.

[jerqi]

Yes, if you suspect it is the problem here, I can put forward a new pr, specify a path in this test class to avoid throwing the exception in the screenshot above.

No, I add the method close to solve this problems.

[kaijchen]

LGTM, thanks @smallzhongfeng.

[jerqi]

Merged. thanks @kaijchen @smallzhongfeng