[MINOR] test: fix static field initialized before TempDir field injected #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zuston this should also be applied for v0.7, one failed test is caused by this. |
advancedxy
commented
Mar 10, 2023
| @@ -56,14 +56,15 @@ | |||
| public class DiskErrorToleranceTest extends ShuffleReadWriteBase { | |||
| private ShuffleServerGrpcClient shuffleServerClient; | |||
|
|
|||
| @TempDir private static File serverTmpDir; | |||
| private static File data1 = new File(serverTmpDir, "data1"); | |||
There was a problem hiding this comment.
serverTmpDir is injected after static variable initialization
kaijchen
approved these changes
Mar 10, 2023
kaijchen
changed the title
kaijchen
pushed a commit
that referenced
this pull request
Mar 10, 2023
…ted (#707) ### What changes were proposed in this pull request? fix UTs ### Why are the changes needed? Makes integration tests passed on local machines ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually verified.
This was referenced Mar 10, 2023
advancedxy
added a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…ted (apache#707) ### What changes were proposed in this pull request? fix UTs ### Why are the changes needed? Makes integration tests passed on local machines ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix UTs
Why are the changes needed?
Makes integration tests passed on local machines
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually verified.