[Improvement]LocalStorage init use multi thread #71 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmjj
reviewed
Jul 26, 2022
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java
Outdated
Show resolved
Hide resolved
|
Test case is needed for this improvement |
|
Could you modify the description according to our pull request template? We will use the description as commit message, the commit message will provide more information to help people understand the code. |
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
============================================
- Coverage 56.39% 56.38% -0.02%
- Complexity 1173 1179 +6
============================================
Files 149 149
Lines 7953 8013 +60
Branches 761 767 +6
============================================
+ Hits 4485 4518 +33
- Misses 3226 3250 +24
- Partials 242 245 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
frankliee
reviewed
Jul 26, 2022
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java
Show resolved
Hide resolved
jerqi
reviewed
Jul 29, 2022
server/src/main/java/org/apache/uniffle/server/storage/LocalStorageManager.java
Show resolved
Hide resolved
jerqi
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
use multi thread to clean local storage
Why are the changes needed?
If shuffle server exit abnormally, there will be many files need to be clear when shuffle server start again and this operation will cost a lot of time
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need