[MINOR] test: test class name should end with Test #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
============================================
+ Coverage 60.63% 62.81% +2.18%
Complexity 1850 1850
============================================
Files 229 215 -14
Lines 12749 10785 -1964
Branches 1064 1064
============================================
- Hits 7730 6775 -955
+ Misses 4609 3660 -949
+ Partials 410 350 -60 see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
Mar 15, 2023
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
### What changes were proposed in this pull request? Rename some tests: * SparkSQLWithDelegationShuffleManagerFallback.java => SparkSQLWithDelegationShuffleManagerFallbackTest.java * SparkSQLWithDelegationShuffleManager.java => SparkSQLWithDelegationShuffleManagerTest.java ### Why are the changes needed? test class name should end with Test ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
### What changes were proposed in this pull request? Rename some tests: * SparkSQLWithDelegationShuffleManagerFallback.java => SparkSQLWithDelegationShuffleManagerFallbackTest.java * SparkSQLWithDelegationShuffleManager.java => SparkSQLWithDelegationShuffleManagerTest.java ### Why are the changes needed? test class name should end with Test ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename some tests:
Why are the changes needed?
test class name should end with Test
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.