Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] chore(ci): test compile in java 11 and 17 with source/target version set #728

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Bump maven-shade-plugin to 3.4.1.
Test compile with java.version set to 11 and 17 in CI.

Why are the changes needed?

Test build in java 11 and java 17.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually.

@kaijchen kaijchen changed the title [MINOR] chore(ci): test compile with java.version 11 and 17 [MINOR] chore(ci): test compile in java 11 and 17 with source/target version set Mar 15, 2023
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kaijchen

@jerqi jerqi merged commit ef0f2dc into apache:master Mar 16, 2023
@kaijchen kaijchen deleted the java-17 branch March 16, 2023 02:08
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this pull request Mar 21, 2023
### What changes were proposed in this pull request?

Bump `maven-shade-plugin` to `3.4.1`.
Test compile with `java.version` set to `11` and `17` in CI.

### Why are the changes needed?

Test build in java 11 and java 17.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
### What changes were proposed in this pull request?

Bump `maven-shade-plugin` to `3.4.1`.
Test compile with `java.version` set to `11` and `17` in CI.

### Why are the changes needed?

Test build in java 11 and java 17.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants