[MINOR] test: untracked files created in ShuffleFlushManagerTest #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
============================================
+ Coverage 60.65% 62.86% +2.21%
- Complexity 1897 1900 +3
============================================
Files 238 224 -14
Lines 13012 11053 -1959
Branches 1091 1091
============================================
- Hits 7892 6949 -943
+ Misses 4682 3725 -957
+ Partials 438 379 -59 see 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kaijchen
changed the title
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…che#745) ### What changes were proposed in this pull request? Fix remoteStorage path in fallbackWrittenWhenMultiStorageManagerEnableTest ### Why are the changes needed? Untracked files created in fallbackWrittenWhenMultiStorageManagerEnableTest ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Before: ```console $ mvn test -Dtest=ShuffleFlushManagerTest#fallbackWrittenWhenMultiStorageManagerEnableTest ... $ git status On branch master Your branch is up to date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed) server/test/ nothing added to commit but untracked files present (use "git add" to track) $ ls server/test fallbackWrittenWhenMultiStorageManagerEnableTest/ ``` After: ```console $ mvn test -Dtest=ShuffleFlushManagerTest#fallbackWrittenWhenMultiStorageManagerEnableTest ... $ git status On branch fix-leak nothing to commit, working tree clean ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix remoteStorage path in fallbackWrittenWhenMultiStorageManagerEnableTest
Why are the changes needed?
Untracked files created in fallbackWrittenWhenMultiStorageManagerEnableTest
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Before:
After: