Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#762] If the storage path is not exist, get file store for its parent. #763

Merged
merged 3 commits into from
Mar 26, 2023

Conversation

xianjingfeng
Copy link
Member

What changes were proposed in this pull request?

If the storage path is not exist, get file store for its parent.

Why are the changes needed?

Fix: #762

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT

xianjingfeng added 2 commits March 25, 2023 16:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Merging #763 (bd16587) into master (567872b) will increase coverage by 2.27%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #763      +/-   ##
============================================
+ Coverage     60.67%   62.94%   +2.27%     
- Complexity     1901     1905       +4     
============================================
  Files           239      225      -14     
  Lines         13031    11074    -1957     
  Branches       1091     1093       +2     
============================================
- Hits           7907     6971     -936     
+ Misses         4686     3723     -963     
+ Partials        438      380      -58     
Impacted Files Coverage Δ
...le/storage/common/DefaultStorageMediaProvider.java 77.50% <100.00%> (+16.89%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy
Copy link
Contributor

@xianjingfeng thanks for your work. The exception shall not be thrown.

@xianjingfeng xianjingfeng merged commit 47cac39 into apache:master Mar 26, 2023
@xianjingfeng xianjingfeng deleted the issue_762 branch March 26, 2023 02:39
xianjingfeng added a commit to xianjingfeng/incubator-uniffle that referenced this pull request Apr 5, 2023
… parent. (apache#763)

### What changes were proposed in this pull request?
If the storage path is not exist, get file store for its parent.

### Why are the changes needed?
Fix: apache#762

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DefaultStorageMediaProvider#getStorageMediaFor fail because of NoSuchFileException
3 participants