[MINOR] build(operator): update clusterrole of controller and webhook #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
approved these changes
Apr 26, 2023
|
LGTM. thanks. |
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
============================================
- Coverage 57.13% 57.09% -0.04%
- Complexity 2147 2148 +1
============================================
Files 321 321
Lines 15655 15655
Branches 1243 1243
============================================
- Hits 8945 8939 -6
- Misses 6204 6212 +8
+ Partials 506 504 -2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Do we need cherry-pick this pr to branch 0.7? |
|
Merged, thanks @wangao1236 |
doesn't need. It's introduced by HPA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update clusterrole of controller and webhook's yaml file.
Why are the changes needed?
If not modified, the new versions of rss-controller and rss-webhook will report permission errors
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually verified.