[#493] improvement: replace putIfAbsent with computeIfAbsent to avoid performance loss in some critical paths
#876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some critical paths
jerqi
changed the title
zuston
reviewed
May 12, 2023
| @@ -241,7 +241,7 @@ protected ShuffleBlockInfo createShuffleBlock(int partitionId, WriterBuffer wb) | |||
|
|
|||
| // it's run in single thread, and is not thread safe | |||
| private int getNextSeqNo(int partitionId) { | |||
| partitionToSeqNo.putIfAbsent(partitionId, 0); | |||
| @@ -544,7 +544,7 @@ public void reportShuffleResult( | |||
| groupedPartitions.get(ssi).add(partitionIdx); | |||
| } | |||
| if (CollectionUtils.isNotEmpty(partitionToBlockIds.get(partitionIdx))) { | |||
| partitionReportTracker.putIfAbsent(partitionIdx, 0); | |||
| partitionReportTracker.computeIfAbsent(partitionIdx, key -> 0); | |||
| @@ -630,7 +630,7 @@ public Roaring64NavigableMap getShuffleResultForMultiPart(String clientType, | |||
| ShuffleServerInfo shuffleServerInfo = entry.getKey(); | |||
| Set<Integer> requestPartitions = Sets.newHashSet(); | |||
| for (Integer partitionId : entry.getValue()) { | |||
| partitionReadSuccess.putIfAbsent(partitionId, 0); | |||
| partitionReadSuccess.computeIfAbsent(partitionId, key -> 0); | |||
| @@ -312,7 +312,7 @@ public static Map<Integer, Roaring64NavigableMap> generatePartitionToBitmap( | |||
| Roaring64NavigableMap shuffleBitmap, int startPartition, int endPartition) { | |||
| Map<Integer, Roaring64NavigableMap> result = Maps.newHashMap(); | |||
| for (int partitionId = startPartition; partitionId < endPartition; partitionId++) { | |||
| result.putIfAbsent(partitionId, Roaring64NavigableMap.bitmapOf()); | |||
| result.computeIfAbsent(partitionId, key -> Roaring64NavigableMap.bitmapOf()); | |||
|
Overall LGTM @cchung100m Left minor comments and please fix the CI failure. Thanks~ |
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
============================================
+ Coverage 56.58% 58.71% +2.13%
- Complexity 2176 2183 +7
============================================
Files 327 307 -20
Lines 15981 13623 -2358
Branches 1263 1258 -5
============================================
- Hits 9043 7999 -1044
+ Misses 6430 5186 -1244
+ Partials 508 438 -70
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
May 13, 2023
zuston
changed the title
putIfAbsent with computeIfAbsent to avoid performance loss in some critical paths
|
Do you want join our WeChat group? If you are willing to do more contribution or have any good idea, feel free to propose.
|
|
Hi @zuston Thanks for the invitation, I have joined the group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zuston
I have updated some critical paths with the replacement, however, there might be some missing pieces, any suggestions would be appreciated.
What changes were proposed in this pull request?
Replace
putIfAbsentwithcomputeIfAbsentin some critical pathsWhy are the changes needed?
Fix: #493
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT