[MINOR] refactor: Reduce the usage of memory in the ShuffleWriter
#877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
changed the title
ShuffleWriterShuffleWriter
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
============================================
+ Coverage 56.58% 58.02% +1.43%
+ Complexity 2176 2041 -135
============================================
Files 327 290 -37
Lines 15981 12661 -3320
Branches 1263 1185 -78
============================================
- Hits 9043 7346 -1697
+ Misses 6430 4909 -1521
+ Partials 508 406 -102 see 41 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zuston
approved these changes
May 12, 2023
This pr is doing similar thing #861 |
|
Merged to master. thanks @zuston |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should immediately remove the
WriteBufferafter we use the methodcreateShuffleBlockto createShuffeBlock. Otherwise we will have the compressed data and uncompressed data at the same time in the memory. JVM's GC can't collect the memory of uncompressed data, because the data have the reference in the mapbuffers.Why are the changes needed?
Reduce the usage of memory.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI passed.