Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#133] feat(netty): Fix IllegalReferenceCountException. #899

Merged
merged 1 commit into from
May 23, 2023

Conversation

leixm
Copy link
Contributor

@leixm leixm commented May 23, 2023

What changes were proposed in this pull request?

The ByteBuf.release() of the block should be called after clearInFlushBuffer is called, otherwise there will be a certain probability of IllegalReferenceCountException at ShuffleBuffer#updateShuffleData -> data.addComponent(true, block.getData().retain());
1.Fix IllegalReferenceCountException,
2.Added ByteBuf.release() when remove resources.

Why are the changes needed?

Fix: #133

Does this PR introduce any user-facing change?

No.

How was this patch tested?

existing UTs.

@leixm
Copy link
Contributor Author

leixm commented May 23, 2023

@smallzhongfeng @jerqi PTAL.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #899 (0d461d0) into master (9c62784) will increase coverage by 1.87%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #899      +/-   ##
============================================
+ Coverage     55.22%   57.09%   +1.87%     
- Complexity     2197     2199       +2     
============================================
  Files           333      313      -20     
  Lines         16444    14087    -2357     
  Branches       1306     1306              
============================================
- Hits           9081     8043    -1038     
+ Misses         6851     5603    -1248     
+ Partials        512      441      -71     
Impacted Files Coverage Δ
...le/storage/handler/impl/LocalFileWriteHandler.java 77.08% <ø> (-0.47%) ⬇️
...rg/apache/uniffle/server/buffer/ShuffleBuffer.java 92.74% <100.00%> (+0.17%) ⬆️
...he/uniffle/server/buffer/ShuffleBufferManager.java 84.28% <100.00%> (+0.05%) ⬆️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jerqi jerqi merged commit 8949e0e into apache:master May 23, 2023
23 of 25 checks passed
@leixm
Copy link
Contributor Author

leixm commented May 23, 2023

@jerqi Thank you for your review.

@leixm
Copy link
Contributor Author

leixm commented May 23, 2023

Seems WriteAndReadMetricsTest is a flaky test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Umbrella] Netty replace Grpc on data transfer
3 participants