Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] refactor: Fix tez workflow and checkstyle #911

Merged
merged 2 commits into from
May 30, 2023

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

Fix tez workflow

Why are the changes needed?

For now, workflow does not build tez client.

jerqi
jerqi previously approved these changes May 30, 2023
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhengchenyu , wait for CI.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #911 (531f761) into master (b08efa3) will increase coverage by 1.81%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #911      +/-   ##
============================================
+ Coverage     55.30%   57.12%   +1.81%     
+ Complexity     2202     2200       -2     
============================================
  Files           333      313      -20     
  Lines         16448    14091    -2357     
  Branches       1308     1308              
============================================
- Hits           9097     8049    -1048     
+ Misses         6838     5599    -1239     
+ Partials        513      443      -70     
Impacted Files Coverage Δ
...c/main/java/org/apache/tez/common/RssTezUtils.java 30.28% <0.00%> (-0.53%) ⬇️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi
Copy link
Contributor

jerqi commented May 30, 2023

@zhengchenyu Could you fix spotbug issues?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhengchenyu , merged to master.

@jerqi jerqi merged commit 1189580 into apache:master May 30, 2023
24 of 27 checks passed
@zhengchenyu zhengchenyu deleted the workflow.tez branch May 30, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants