[MINOR] improvement(mr): Add @Test to activate test case #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems unrelated to #854. We use minor if this pr fix minor issue. Feat means feature. So I change the label to improvement. |
jerqi
changed the title
I think it does not matter whether it related or not. |
We should use correct titile. |
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
============================================
+ Coverage 55.53% 57.37% +1.83%
Complexity 2246 2246
============================================
Files 341 321 -20
Lines 16626 14266 -2360
Branches 1327 1327
============================================
- Hits 9234 8185 -1049
+ Misses 6863 5622 -1241
+ Partials 529 459 -70 see 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add @test to activate test case
Why are the changes needed?
Just for Add @test to activate test case
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test