Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#927] Improvement: improve the control of server heartbeat #928

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

summaryzb
Copy link
Contributor

What changes were proposed in this pull request?

Eleminate rss.server.heartbeat.timeout replaced with rss.server.heartbeat.interval

Why are the changes needed?

#927

Does this PR introduce any user-facing change?

Yes, rss.server.heartbeat.timeout will effect nothing

How was this patch tested?

UnitTest

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #928 (52a457c) into master (d09cdc2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #928      +/-   ##
============================================
- Coverage     55.53%   55.51%   -0.03%     
  Complexity     2246     2246              
============================================
  Files           341      341              
  Lines         16626    16620       -6     
  Branches       1327     1327              
============================================
- Hits           9234     9227       -7     
  Misses         6863     6863              
- Partials        529      530       +1     
Impacted Files Coverage Δ
...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java 0.00% <ø> (ø)
...a/org/apache/uniffle/server/RegisterHeartBeat.java 87.71% <ø> (-0.22%) ⬇️
...a/org/apache/uniffle/server/ShuffleServerConf.java 99.43% <ø> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@summaryzb
Copy link
Contributor Author

PTAL @jerqi

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @summaryzb , the pipeline of mr-hadoop3.2 's failure is unrelated to this pr, merged to master.

@jerqi jerqi merged commit 0ea306f into apache:master Jun 5, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants