[#978][Improvement] Provides a tool class to format CLI output content #979
Conversation
yl09099
force-pushed
the
uniffle-978
branch
2 times, most recently
from
4ba0128
to
be1e07b
Compare
| @Test | ||
| public void testTableFormat() { | ||
|
|
||
| String expectStr = "+----------------------------------------" |
There was a problem hiding this comment.
Is there a better way? This looks difficult to read. @zuston Do you have a good suggestion?
There was a problem hiding this comment.
Why do we need 9 rows? @yl09099
There was a problem hiding this comment.
Is there a better way? This looks difficult to read. @zuston Do you have a good suggestion?
Loading from the file?
There was a problem hiding this comment.
The code looks better, let's wait for @zuston the suggestion.
yl09099
force-pushed
the
uniffle-978
branch
2 times, most recently
from
b8ffd25
to
6c4becf
Compare
Codecov Report
@@ Coverage Diff @@
## master #979 +/- ##
=============================================
+ Coverage 44.23% 57.00% +12.76%
- Complexity 0 2084 +2084
=============================================
Files 20 309 +289
Lines 2360 12971 +10611
Branches 0 1200 +1200
=============================================
+ Hits 1044 7394 +6350
- Misses 1245 5159 +3914
- Partials 71 418 +347
... and 328 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@jerqi This error is not caused by me, take a hard look |
|
It has been modified, please review it @slfan1989 @zuston |
Could this apply one cli command in this PR? I'm not sure we will use this in the current implementation currently. Anyway, this looks good to me. |
|
Merged. Thanks @yl09099 |
What changes were proposed in this pull request?
Provides a tool class to format CLI output content.
Why are the changes needed?
Fix: #978
Does this PR introduce any user-facing change?
The CLI command display is more beautiful.Similar to：
How was this patch tested?
Added UT.