-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#957] feat(tez): Tez examples integration test #982
Conversation
This PR is not ready to review. The integration test will fail until some issue is solved. |
b3f3d42
to
351dea9
Compare
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
============================================
+ Coverage 53.57% 54.79% +1.22%
- Complexity 2511 2519 +8
============================================
Files 378 359 -19
Lines 20528 18170 -2358
Branches 1773 1776 +3
============================================
- Hits 10997 9956 -1041
+ Misses 8835 7585 -1250
+ Partials 696 629 -67 see 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1900ef5
to
c7c35db
Compare
<dependency> | ||
<groupId>com.google.guava</groupId> | ||
<artifactId>guava</artifactId> | ||
<version>21.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove the version? We should manage the version to the parent pom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not remove this version.
In fact tez-0.9.1 is not compatibility with hadoop-3.2.1 until TEZ-4124. guava-21.0 is an internal version, this is used to solve the compatibility problem.
I found integration-test/mr/pom.xml also use this version, maybe a same problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some comments for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zhengchenyu
What changes were proposed in this pull request?
Add integration test for tez
Why are the changes needed?
To construct tez test pipeline, we need integration test.
How was this patch tested?
integration test.