Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#957] feat(tez): Tez examples integration test #982

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

zhengchenyu
Copy link
Collaborator

What changes were proposed in this pull request?

Add integration test for tez

Why are the changes needed?

To construct tez test pipeline, we need integration test.

How was this patch tested?

integration test.

@zhengchenyu zhengchenyu marked this pull request as draft June 29, 2023 09:04
@zhengchenyu
Copy link
Collaborator Author

zhengchenyu commented Jun 29, 2023

@zhengchenyu zhengchenyu deleted the tez.integeration.test branch June 29, 2023 09:32
@zhengchenyu zhengchenyu reopened this Jul 6, 2023
@zhengchenyu zhengchenyu marked this pull request as ready for review July 6, 2023 01:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #982 (af621b3) into master (b759588) will increase coverage by 1.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #982      +/-   ##
============================================
+ Coverage     53.57%   54.79%   +1.22%     
- Complexity     2511     2519       +8     
============================================
  Files           378      359      -19     
  Lines         20528    18170    -2358     
  Branches       1773     1776       +3     
============================================
- Hits          10997     9956    -1041     
+ Misses         8835     7585    -1250     
+ Partials        696      629      -67     

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pom.xml Show resolved Hide resolved
@zhengchenyu zhengchenyu restored the tez.integeration.test branch July 11, 2023 03:25
integration-test/tez/pom.xml Outdated Show resolved Hide resolved
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>21.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the version? We should manage the version to the parent pom.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can not remove this version.
In fact tez-0.9.1 is not compatibility with hadoop-3.2.1 until TEZ-4124. guava-21.0 is an internal version, this is used to solve the compatibility problem.
I found integration-test/mr/pom.xml also use this version, maybe a same problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some comments for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

integration-test/tez/pom.xml Outdated Show resolved Hide resolved
integration-test/tez/pom.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhengchenyu

@jerqi jerqi merged commit 889f67e into apache:master Jul 12, 2023
29 checks passed
@zhengchenyu zhengchenyu deleted the tez.integeration.test branch July 12, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants