[core] fix memory leak

apache · Jan 3, 2019 · 2e2c05d · 2e2c05d
1 parent cf9f457
commit 2e2c05d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -700,9 +700,8 @@ - (void)destroyInstance:(NSString *)instance
         WXPerformBlockOnComponentThread(^{
             [WXCoreBridge destroyDataRenderInstance:instance];
         });
-    } else {
-        [self callJSMethod:@"destroyInstance" args:@[instance]];
     }
+    [self callJSMethod:@"destroyInstance" args:@[instance]];
 }
 
 - (void)forceGarbageCollection

diff --git a/weex_core/Source/core/data_render/vnode/vcomponent.cc b/weex_core/Source/core/data_render/vnode/vcomponent.cc
@@ -45,7 +45,11 @@ VComponent::VComponent(ExecState *exec_state, int template_id,
       root_vnode_(nullptr),
       exec_state_(exec_state) {}
 
-VComponent::~VComponent() {}
+VComponent::~VComponent() {
+  if (listener_ && !has_moved_) {
+    listener_->OnDestroyed(this);
+  }
+}
 
 static bool Equals(Value a, Value b) {
   if (a.type != b.type) {