review

apache · Aug 30, 2019 · 36aa642 · 36aa642
1 parent eca9162
commit 36aa642
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java b/android/sdk/src/main/java/com/taobao/weex/ui/action/GraphicActionAnimation.java
@@ -204,11 +204,11 @@ ObjectAnimator createAnimator(final View target, final int viewPortWidth) {
         ViewGroup.LayoutParams layoutParams = target.getLayoutParams();
         if (!TextUtils.isEmpty(style.width)) {
           holders.add(PropertyValuesHolder.ofInt(new WidthProperty(), layoutParams.width,
-              (int) WXViewUtils.getRealPxByWidth(style.width,0.0f, viewPortWidth)));
+              (int) WXViewUtils.getRealPxByWidth(style.width, Float.NaN, viewPortWidth)));
         }
         if (!TextUtils.isEmpty(style.height)) {
           holders.add(PropertyValuesHolder.ofInt(new HeightProperty(), layoutParams.height,
-              (int) WXViewUtils.getRealPxByWidth(style.width,0.0f, viewPortWidth)));
+              (int) WXViewUtils.getRealPxByWidth(style.width, Float.NaN, viewPortWidth)));
         }
       }
 

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java b/android/sdk/src/main/java/com/taobao/weex/ui/animation/TransformParser.java
@@ -243,7 +243,7 @@ private Float parseCameraDistance(List<String> rawValue){
         return new LinkedHashMap<>();
     }
 
-    protected static Pair<Float, Float> parsePivot(@Nullable String transformOrigin,
+    static Pair<Float, Float> parsePivot(@Nullable String transformOrigin,
                                                  int width, int height, int viewportW) {
         if (!TextUtils.isEmpty(transformOrigin)) {
             int firstSpace = transformOrigin.indexOf(FunctionParser.SPACE);

diff --git a/android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java b/android/sdk/src/main/java/com/taobao/weex/utils/WXViewUtils.java
@@ -312,9 +312,9 @@ public static float getRealPxByWidth(Object value, float df, int customViewport)
                 pxValue = Float.parseFloat(temp);
             }
         } catch (NumberFormatException nfe) {
-            WXLogUtils.e("Argument format error! value is " + temp, WXLogUtils.getStackTrace(nfe));
+            WXLogUtils.e(WXLogUtils.getStackTrace(nfe));
         } catch (Exception e) {
-            WXLogUtils.e("Argument error! value is " + temp, WXLogUtils.getStackTrace(e));
+            WXLogUtils.e(WXLogUtils.getStackTrace(e));
         }
         if (mUseWebPx) {
             return (float) Math.rint(pxValue);