Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Commit

Permalink
[Android] record ipc exception history and weexCoreThread stackTrace …
Browse files Browse the repository at this point in the history 
…when white screen or js process died/reload (#2826)
  • Loading branch information
@lucky-chen @Darin726
lucky-chen authored and Darin726 committed Aug 14, 2019
1 parent c72e6b5 commit a994ce9
Show file tree
Hide file tree
Showing 7 changed files with 67 additions and 37 deletions.
1 change: 1 addition & 0 deletions android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,7 @@ private void checkWhiteScreen(){
Map<String,String> args = new HashMap<>(1);
String vieTreeMsg = WhiteScreenUtils.takeViewTreeSnapShot(this);
args.put("viewTree",null == vieTreeMsg?"null viewTreeMsg":vieTreeMsg);
args.put("weexCoreThreadStackTrace",WXBridgeManager.getInstance().getWeexCoreThreadStackTrace());

for (Map.Entry<String,String> entry: WXStateRecord.getInstance().getStateInfo().entrySet()){
args.put(entry.getKey(),entry.getValue());
Expand Down
39 changes: 33 additions & 6 deletions android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,10 @@ public int callReportCrashReloadPage(String instanceId, String crashFile) {
url = instance.getBundleUrl();
instance.setHasException(true);
}
Map<String,String> extInfo = new HashMap<>(2);
extInfo.put("weexCoreThreadStackTrace:",WXBridgeManager.getInstance().getWeexCoreThreadStackTrace());
extInfo.put("wxStateInfo",WXStateRecord.getInstance().getStateInfo().toString());

if(!isCrashFileEmpty) {
try {
if (WXEnvironment.getApplication() != null) {
Expand All @@ -894,15 +898,15 @@ public int callReportCrashReloadPage(String instanceId, String crashFile) {
WXLogUtils.e(WXLogUtils.getStackTrace(e));
}
WXStateRecord.getInstance().onJSCCrash();
callReportCrash(crashFile, instanceId, url);
callReportCrash(crashFile, instanceId, url,extInfo);
} else {
WXStateRecord.getInstance().onJSEngineReload();
commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, WXErrorCode.WX_ERR_RELOAD_PAGE, "reboot jsc Engine", instanceId, url);
commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, WXErrorCode.WX_ERR_RELOAD_PAGE, "reboot jsc Engine", instanceId, url,extInfo);
}

if (reInitCount > CRASHREINIT) {
WXExceptionUtils.commitCriticalExceptionRT("jsEngine", WXErrorCode.WX_ERR_RELOAD_PAGE_EXCEED_LIMIT,
"callReportCrashReloadPage","reInitCount:"+reInitCount,null);
"callReportCrashReloadPage","reInitCount:"+reInitCount,extInfo);
return IWXBridge.INSTANCE_RENDERING_ERROR;
}
reInitCount++;
Expand Down Expand Up @@ -974,7 +978,7 @@ public boolean shouldReloadCurrentInstance(String aUrl) {
return false;
}

public void callReportCrash(String crashFile, final String instanceId, final String url) {
public void callReportCrash(String crashFile, final String instanceId, final String url,final Map<String,String> extInfo) {
// statistic weex core process crash
Date date = new Date();
DateFormat format = new SimpleDateFormat("yyyyMMddHHmmss", Locale.US);
Expand Down Expand Up @@ -1005,7 +1009,7 @@ public void run() {
// }
result.append(s + "\n");
}
commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, WXErrorCode.WX_ERR_JSC_CRASH, result.toString(), instanceId, url);
commitJscCrashAlarmMonitor(IWXUserTrackAdapter.JS_BRIDGE, WXErrorCode.WX_ERR_JSC_CRASH, result.toString(), instanceId, url,extInfo);
br.close();
} catch (Exception e) {
WXLogUtils.e(WXLogUtils.getStackTrace(e));
Expand Down Expand Up @@ -1473,7 +1477,7 @@ private void invokeRefreshInstance(String instanceId, WXRefreshData refreshData)
}

public void commitJscCrashAlarmMonitor(final String type, final WXErrorCode errorCode, String errMsg,
String instanceId, String url) {
String instanceId, String url,Map<String, String> extInfo) {
if (TextUtils.isEmpty(type) || errorCode == null) {
return;
}
Expand All @@ -1483,6 +1487,9 @@ public void commitJscCrashAlarmMonitor(final String type, final WXErrorCode erro
String exception = "weex core process crash and restart exception";
Map<String, String> extParams = new HashMap<String, String>();
extParams.put("jscCrashStack", errMsg);
if (null != extInfo){
extParams.putAll(extInfo);
}
IWXJSExceptionAdapter adapter = WXSDKManager.getInstance().getIWXJSExceptionAdapter();
if (adapter != null) {
WXJSExceptionInfo jsException = new WXJSExceptionInfo(instanceId, url, errorCode, method, exception, extParams);
Expand Down Expand Up @@ -3614,4 +3621,24 @@ private void onJsFrameWorkInitSuccees() {
}
mWeexCoreEnvOptions.clear();
}

public String getWeexCoreThreadStackTrace(){
if (null == mJSThread){
return "null == mJSThread";
}
StringBuilder stringBuilder = new StringBuilder();

try {
stringBuilder.append(String.format("Thread Name: '%s'\n", mJSThread.getName()));
stringBuilder.append(String.format(Locale.ENGLISH,"\"%s\" prio=%d tid=%d %s\n", mJSThread.getName(), mJSThread.getPriority(), mJSThread.getId(), mJSThread.getState()));

for (StackTraceElement e: mJSThread.getStackTrace()){
stringBuilder.append(String.format("\tat %s\n", e.toString()));
}
} catch (Exception var8) {
Log.e("weex", "getJSThreadStackTrace error:", var8);
}
return stringBuilder.toString();
}

}
21 changes: 9 additions & 12 deletions android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public class WXStateRecord {
private RecordList<Info> mJscCrashHistory;
private RecordList<Info> mJscReloadHistory;
private RecordList<Info> mJsThradWatchHistory;
private RecordList<Info> mIPCExceptionHistory;

private static class SingleTonHolder {
private static final WXStateRecord S_INSTANCE = new WXStateRecord();
Expand All @@ -60,6 +61,7 @@ private WXStateRecord() {
mJscCrashHistory = new RecordList<>(10);
mJscReloadHistory = new RecordList<>(10);
mJsThradWatchHistory = new RecordList<>(20);
mIPCExceptionHistory = new RecordList<>(20);
}

/**
Expand All @@ -77,6 +79,11 @@ public void recordAction(String instanceId, String action) {
recordCommon(mActionHistory,new Info(WXUtils.getFixUnixTime(), instanceId, action));
}

public void recordIPCException (String instanceId,String exception){
String shortException = exception.length() > 200 ?exception.substring(0,200) : exception;
recordCommon(mIPCExceptionHistory,new Info(WXUtils.getFixUnixTime(), instanceId, shortException));
}

/**
* check onJSFMInit time,and we know when jsfm is init sucess in reloadJsEngine case
*/
Expand Down Expand Up @@ -134,6 +141,7 @@ public Map<String, String> getStateInfo() {
reportTimeLineInfo.addAll(mJscCrashHistory);
reportTimeLineInfo.addAll(mJscReloadHistory);
reportTimeLineInfo.addAll(mJsThradWatchHistory);
reportTimeLineInfo.addAll(mIPCExceptionHistory);
Collections.sort(reportTimeLineInfo);
stateInfo.put("stateInfoList",reportTimeLineInfo.toString());

Expand All @@ -147,17 +155,6 @@ public RecordList(int maxSize) {
super();
this.maxSize = maxSize;
}

@Override
public String toString() {
StringBuilder builder = new StringBuilder();
E e = this.poll();
while (null != e){
builder.append('[').append(e.toString()).append(']').append("->");
e = this.poll();
}
return builder.toString();
}
}

private static class Info implements Comparable<Info>{
Expand All @@ -174,7 +171,7 @@ public Info(long time, String instance, String msg) {
@Override
public String toString() {
return new StringBuilder()
.append(instanceId).append(',').append(time).append(',').append(msg)
.append('[').append(instanceId).append(',').append(time).append(',').append(msg).append("]->")
.toString();
}

Expand Down
4 changes: 4 additions & 0 deletions android/sdk/src/main/java/com/taobao/weex/utils/WXLogUtils.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import com.taobao.weex.WXEnvironment;
import com.taobao.weex.WXSDKInstance;
import com.taobao.weex.WXSDKManager;
import com.taobao.weex.performance.WXStateRecord;
import com.taobao.weex.utils.tools.LogDetail;

import java.io.IOException;
Expand Down Expand Up @@ -81,6 +82,9 @@ private static void log(String tag, String msg, LogLevel level){
if(TextUtils.isEmpty(msg) || TextUtils.isEmpty(tag) || level == null || TextUtils.isEmpty(level.getName())){
return;
}
if (level == LogLevel.ERROR && !TextUtils.isEmpty(msg) && msg.contains("IPCException")){
WXStateRecord.getInstance().recordIPCException("ipc",msg);
}

if(sLogWatcher !=null){
sLogWatcher.onLog(level.getName(), tag, msg);
Expand Down
36 changes: 18 additions & 18 deletions weex_core/Source/android/bridge/script/script_side_in_multi_process.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ int ScriptSideInMultiProcess::InitFramework(
return false;
}
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException InitFramework %s", e.msg());
return false;
}
return true;
Expand Down Expand Up @@ -88,7 +88,7 @@ int ScriptSideInMultiProcess::InitAppFramework(
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
return result->get<jint>();
} catch (IPCException &e) {
LOGE("initAppFramework error %s", e.msg());
LOGE("IPCException initAppFramework error %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand All @@ -115,7 +115,7 @@ int ScriptSideInMultiProcess::CreateAppContext(const char *instanceId,
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
return result->get<jint>();
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException CreateAppContext %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -156,7 +156,7 @@ std::unique_ptr<WeexJSResult> ScriptSideInMultiProcess::ExecJSOnAppWithResult(co
return ret;

} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJSOnAppWithResult %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -204,7 +204,7 @@ int ScriptSideInMultiProcess::CallJSOnAppContext(
}
return result->get<jint>();
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException CallJSOnAppContext %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand All @@ -228,7 +228,7 @@ int ScriptSideInMultiProcess::DestroyAppContext(const char *instanceId) {
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
return true;
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException DestroyAppContext %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand All @@ -255,7 +255,7 @@ int ScriptSideInMultiProcess::ExecJsService(const char *source) {
}
return result->get<jint>();
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJsService error %s", e.msg());
return false;
}
}
Expand Down Expand Up @@ -304,14 +304,14 @@ int ScriptSideInMultiProcess::ExecJS(const char *instanceId,

std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
if (result->getType() != IPCType::INT32) {
LOGE("execJS Unexpected result type");
LOGE("IPCException execJS Unexpected result type");
return false;
}

return result->get<jint>();

} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJS %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -380,7 +380,7 @@ std::unique_ptr<WeexJSResult> ScriptSideInMultiProcess::ExecJSWithResult(

return ret;
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJSWithResult %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand All @@ -396,7 +396,7 @@ void ScriptSideInMultiProcess::ExecJSWithCallback(
std::unique_ptr<WeexJSResult> ret;
try {
if(sender_ == nullptr) {
LOGE("ExecJSWithResult sender is null");
LOGE("IPCException ExecJSWithResult sender is null");
return;
}
std::unique_ptr<IPCSerializer> serializer(createIPCSerializer());
Expand All @@ -421,7 +421,7 @@ void ScriptSideInMultiProcess::ExecJSWithCallback(
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());

} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJSWithCallback %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -461,7 +461,7 @@ int ScriptSideInMultiProcess::CreateInstance(
}
return result->get<jint>();
} catch (IPCException &e) {
LOGE("%s %s","Create Instance is failed and Error msg is", e.msg());
LOGE("IPCException %s %s","Create Instance is failed and Error msg is", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -498,7 +498,7 @@ std::unique_ptr<WeexJSResult> ScriptSideInMultiProcess::ExecJSOnInstance(const c
string[ret->length] = '\0';
return ret;
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException ExecJSOnInstance %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand Down Expand Up @@ -526,7 +526,7 @@ int ScriptSideInMultiProcess::DestroyInstance(const char *instanceId) {
}
return result->get<jint>();
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException DestroyInstance %s", e.msg());
// report crash here
WeexCoreManager::Instance()
->getPlatformBridge()
Expand All @@ -548,7 +548,7 @@ int ScriptSideInMultiProcess::UpdateGlobalConfig(const char *config) {
std::unique_ptr<IPCBuffer> buffer = serializer->finish();
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException UpdateGlobalConfig %s", e.msg());
}
return true;
}
Expand All @@ -569,7 +569,7 @@ int ScriptSideInMultiProcess::UpdateInitFrameworkParams(const std::string &key,
std::unique_ptr<IPCBuffer> buffer = serializer->finish();
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException UpdateInitFrameworkParams %s", e.msg());
}
return true;

Expand All @@ -588,7 +588,7 @@ void ScriptSideInMultiProcess::SetLogType(const int logLevel, const bool isPerf)
std::unique_ptr<IPCBuffer> buffer = serializer->finish();
std::unique_ptr<IPCResult> result = sender_->send(buffer.get());
} catch (IPCException &e) {
LOGE("%s", e.msg());
LOGE("IPCException SetLogType %s", e.msg());
}
return;
}
Expand Down
2 changes: 1 addition & 1 deletion weex_core/Source/android/multiprocess/weex_js_connection.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ static void *newIPCServer(void *_td) {
futexPageQueue->spinWaitPeer();
listener->listen();
} catch (IPCException &e) {
LOGE("server died");
LOGE("IPCException server died %s",e.msg());
closeServerFd(td->ipcServerFd);
base::android::DetachFromVM();
pthread_exit(NULL);
Expand Down
1 change: 1 addition & 0 deletions weex_core/Source/third_party/IPC/IPCFutexPageQueue.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ void IPCFutexPageQueue::lock(size_t id, bool checkFinish)
break;
}
struct timespec waitTime = { m_timeoutSec, 0 };
IPC_LOGE("IPCException IPCFutexPageQueue:: start futex wait");
int futexReturn = __futex(pageStart + 1, FUTEX_WAIT, 0, &waitTime);
if (futexReturn == -1) {
int myerrno = errno;
Expand Down

0 comments on commit a994ce9

Please sign in to comment.