Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[WEEX-203][Android] base64 font-face support #1006

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

misakuo
Copy link
Member

@misakuo misakuo commented Jan 29, 2018

  • support url('data:font/truetype;charset=utf-8;base64,...') to import font-face
  • change the font file cache directory from external storage to application cache

Testcase:
http://dotwe.org/vue/6472fc77dff5afda68864c070643f5ce

@weex-bot
Copy link

weex-bot commented Jan 29, 2018

Fails
🚫 Running your Dangerfile has Failed

Danger has errored

Error: TypeError

TypeError: Cannot read property 'code' of null
    at Object.<anonymous> (./dangerfile-android.js:101:126)
    at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:446:13)
    at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:294:14)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
    at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
    at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
    at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
    at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
    at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)

Generated by 🚫 dangerJS

Copy link
Member

@gubaojian gubaojian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@asfgit asfgit merged commit 3976636 into apache:master Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants