New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-203][Android] base64 font-face support #1006

Merged
merged 1 commit into from Feb 8, 2018

Conversation

Projects
None yet
4 participants
@misakuo
Contributor

misakuo commented Jan 29, 2018

  • support url('data:font/truetype;charset=utf-8;base64,...') to import font-face
  • change the font file cache directory from external storage to application cache

Testcase:
http://dotwe.org/vue/6472fc77dff5afda68864c070643f5ce

@weex-bot

This comment has been minimized.

weex-bot commented Jan 29, 2018

Fails
🚫 Running your Dangerfile has Failed

Danger has errored

Error: TypeError

TypeError: Cannot read property 'code' of null
    at Object.<anonymous> (./dangerfile-android.js:101:126)
    at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:446:13)
    at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:294:14)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
    at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
    at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
    at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
    at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
    at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
    at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)

Generated by 🚫 dangerJS

@gubaojian

great work

@asfgit asfgit merged commit 3976636 into apache:master Feb 8, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment