Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[Android] Fix WebSocket operation on main thread #1015
Conversation
misakuo
added some commits
Dec 26, 2017
This comment has been minimized.
This comment has been minimized.
weex-bot
commented
Feb 5, 2018
•
Danger has erroredError: TypeError TypeError: Cannot read property 'code' of null
at Object.<anonymous> (./dangerfile-android.js:98:126)
at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:446:13)
at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:294:14)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)
Generated by |
misakuo
referenced this pull request
Feb 6, 2018
Closed
* [android] close #123, websocket operate on main thread #1014
asfgit
merged commit 78a6e67
into
apache:master
Feb 8, 2018
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
misakuo commentedFeb 5, 2018
No description provided.