New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-241][iOS] add WXVideoComponent "poster" attribute #1051

Merged
merged 2 commits into from Mar 12, 2018

Conversation

Projects
None yet
4 participants
@xuyouyang
Contributor

xuyouyang commented Mar 7, 2018

feature:241

@weex-bot

This comment has been minimized.

weex-bot commented Mar 7, 2018

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@acton393

This comment has been minimized.

Member

acton393 commented Mar 7, 2018

hi, @xuyouyang what's the "poster" feature, is it the paused picture about player display?

@xuyouyang

This comment has been minimized.

Contributor

xuyouyang commented Mar 7, 2018

NO.
The poster attribute specifies an image to be shown while the video is downloading, or until the user hits the play button. If this is not included, the first frame of the video will be used instead.
You can see this "https://www.w3schools.com/tags/att_video_poster.asp"
It is a attribute in HTML <video> tag
@acton393

@acton393

This comment has been minimized.

Member

acton393 commented Mar 7, 2018

@xuyouyang I got it and find the w3c rules about it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

thanks, we can make it more standard by add more attributes and styles, what about Android?
documentation will be updated when this merged

@@ -85,6 +89,13 @@ - (id)init
}
[self addSubview:_playerViewController.view];
_posterImageView = [[UIImageView alloc] init];

This comment has been minimized.

@acton393

acton393 Mar 7, 2018

Member

How about lazy load when front-end developer specify the poster attributes

This comment has been minimized.

@xuyouyang

xuyouyang Mar 8, 2018

Contributor

good ideal! I will modify this later.

@acton393

This comment has been minimized.

Member

acton393 commented Mar 7, 2018

@xuyouyang as the development process shows, we need create a jira issue in apache, and format your pull request title and commit log.

I have created a jira issue for this feature, and the issue id is WEEX-241, the issue address is https://issues.apache.org/jira/browse/WEEX-241

what you need to do next is to update the title as the following format
[WEEX-jiraId][iOS/Android] summary

thanks

@xuyouyang

This comment has been minimized.

Contributor

xuyouyang commented Mar 8, 2018

OK. Thank you very much! @acton393

@xuyouyang xuyouyang changed the title from + [iOS] add WXVideoComponent "poster" attribute. to [WEEX-241][iOS] add WXVideoComponent "poster" attribute Mar 8, 2018

@acton393

This comment has been minimized.

Member

acton393 commented Mar 8, 2018

@xuyouyang It look good to me and it will be accepted, thank you.
It would be better if Android player can support poster attributes.

@xuyouyang

This comment has been minimized.

Contributor

xuyouyang commented Mar 8, 2018

@acton393 Ha, it's sorry that I am not familiar with Android develop very much.😂

@asfgit asfgit merged commit b0e4455 into apache:master Mar 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xuyouyang xuyouyang deleted the xuyouyang:ios-feature-videoPoster branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment