Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[WEEX-241][iOS] add WXVideoComponent "poster" attribute #1051

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

xuyouyang
Copy link
Contributor

@xuyouyang xuyouyang commented Mar 7, 2018

  • [iOS] add WXVideoComponent poster feature and add support "poster" attribute to

feature:241

@weex-bot
Copy link

weex-bot commented Mar 7, 2018

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@acton393
Copy link
Member

acton393 commented Mar 7, 2018

hi, @xuyouyang what's the "poster" feature, is it the paused picture about player display?

@xuyouyang
Copy link
Contributor Author

xuyouyang commented Mar 7, 2018

NO.
The poster attribute specifies an image to be shown while the video is downloading, or until the user hits the play button. If this is not included, the first frame of the video will be used instead.
You can see this "https://www.w3schools.com/tags/att_video_poster.asp"
It is a attribute in HTML <video> tag
@acton393

@acton393
Copy link
Member

acton393 commented Mar 7, 2018

@xuyouyang I got it and find the w3c rules about it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

thanks, we can make it more standard by add more attributes and styles, what about Android?
documentation will be updated when this merged

@@ -85,6 +89,13 @@ - (id)init
}

[self addSubview:_playerViewController.view];

_posterImageView = [[UIImageView alloc] init];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about lazy load when front-end developer specify the poster attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good ideal! I will modify this later.

@acton393
Copy link
Member

acton393 commented Mar 7, 2018

@xuyouyang as the development process shows, we need create a jira issue in apache, and format your pull request title and commit log.

I have created a jira issue for this feature, and the issue id is WEEX-241, the issue address is https://issues.apache.org/jira/browse/WEEX-241

what you need to do next is to update the title as the following format
[WEEX-jiraId][iOS/Android] summary

thanks

@xuyouyang
Copy link
Contributor Author

OK. Thank you very much! @acton393

@xuyouyang xuyouyang changed the title + [iOS] add WXVideoComponent "poster" attribute. [WEEX-241][iOS] add WXVideoComponent "poster" attribute Mar 8, 2018
@acton393
Copy link
Member

acton393 commented Mar 8, 2018

@xuyouyang It look good to me and it will be accepted, thank you.
It would be better if Android player can support poster attributes.

@xuyouyang
Copy link
Contributor Author

@acton393 Ha, it's sorry that I am not familiar with Android develop very much.😂

@asfgit asfgit merged commit b0e4455 into apache:master Mar 12, 2018
@xuyouyang xuyouyang deleted the ios-feature-videoPoster branch March 12, 2018 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants