Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Weex-260][android]switch supports setting color #1085

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

whn9527
Copy link
Contributor

@whn9527 whn9527 commented Mar 26, 2018

Hi, It's solution to support setting color for <switch> component in android. And the api was according to ios design, a slight difference is <switch> can accept 4 attributes in android:

android ios
tint-color
on-tint-color
thumb-tint-color
on-thumb-tint-color ×

Weex Vue Demo: http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d

@weex-bot
Copy link

weex-bot commented Mar 26, 2018

Fails
🚫 android platform run unit test failed!
Messages
📖 android test finished.

Generated by 🚫 dangerJS

@acton393
Copy link
Member

@gubaojian @misakuo please take a review

@gubaojian
Copy link
Member

switch great support, please attach dotwe.org example link

@whn9527
Copy link
Contributor Author

whn9527 commented Mar 29, 2018

demo link please look at http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d

@acton393
Copy link
Member

acton393 commented Apr 1, 2018

hi @whn9527 maybe your commit message should be the format like

[WEEX-jira][iOS/Android] summary 
   
description 


Bug/ImprovementId(jira ID)

not just like *[Android] later

see more development-process

thanks

@asfgit asfgit merged commit 8255eda into apache:master Apr 1, 2018
@whn9527
Copy link
Contributor Author

whn9527 commented Apr 2, 2018

Thanks for reminding, I will pay attention next time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants