New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Weex-260][android]switch supports setting color #1085

Merged
merged 1 commit into from Apr 1, 2018

Conversation

Projects
None yet
5 participants
@whn9527
Contributor

whn9527 commented Mar 26, 2018

Hi, It's solution to support setting color for <switch> component in android. And the api was according to ios design, a slight difference is <switch> can accept 4 attributes in android:

android ios
tint-color
on-tint-color
thumb-tint-color
on-thumb-tint-color ×

Weex Vue Demo: http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d

@weex-bot

This comment has been minimized.

weex-bot commented Mar 26, 2018

Fails
🚫 android platform run unit test failed!
Messages
📖 android test finished.

Generated by 🚫 dangerJS

@acton393

This comment has been minimized.

Member

acton393 commented Mar 29, 2018

@gubaojian @misakuo please take a review

@gubaojian

This comment has been minimized.

Member

gubaojian commented Mar 29, 2018

switch great support, please attach dotwe.org example link

@whn9527

This comment has been minimized.

Contributor

whn9527 commented Mar 29, 2018

@acton393

This comment has been minimized.

Member

acton393 commented Apr 1, 2018

hi @whn9527 maybe your commit message should be the format like

[WEEX-jira][iOS/Android] summary 
   
description 


Bug/ImprovementId(jira ID)

not just like *[Android] later

see more development-process

thanks

@asfgit asfgit merged commit 8255eda into apache:master Apr 1, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@whn9527

This comment has been minimized.

Contributor

whn9527 commented Apr 2, 2018

Thanks for reminding, I will pay attention next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment