New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-270][iOS]WXListComponent should add reload type of data update #1095

Merged
merged 2 commits into from Apr 1, 2018

Conversation

Projects
None yet
4 participants
@bbmjja8123
Contributor

bbmjja8123 commented Mar 30, 2018

Currently WXListComponent data update only supports insertRows. This can't be satisfied under some drop-down loading scenes. For example, the pulldown load needs to be positioned to the original position. When the tableView is still decelerating and inserts and tries to fix the position, the cell will blink. Because when decelerating, the externally modified contentOffset will be re-edited by the internal implementation of tableView, altering contentOffset alternately will cause flicker problems. If you use the tableView reloadData this is not a problem, so you need to support the WXListComponent in the drop-down restore location scene to add the reload attribute.

feat:270

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.
jianjun.mjj
[WEEX-270][iOS]WXListComponent should add reload type of data update
Currently WXListComponent data update only supports insertRows. This can't be satisfied under some drop-down loading scenes. For example, the pulldown load needs to be positioned to the original position. When the tableView is still decaling and inserts and tries to fix the position, the cell will blink. Because when deceiring, the externally modified contentOffset will be re-edited by the internal implementation of tableView, altering contentOffset alternately will cause flicker problems. If you use the tableView reloadData this is not a problem, so you need to support the WXListComponent in the drop-down restore location scene to add the reload attribute.

feat:270
@weex-bot

This comment has been minimized.

weex-bot commented Mar 30, 2018

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

[WEEX-271][iOS]Extend the pulldown WXRefreshComponent to support imme…
…diate load of the appear

WXRefreshComponent current only support the ②, shuold add new type of①.

// ①refreshForAppear: load more when refresh component begin appear(if scroll is dragging or decelerating, should delay)

 // ②refreshForWholeVisible: load more until the whole refresh component visible

NSString *_refreshType;

Improvement:271
@acton393

This comment has been minimized.

Member

acton393 commented Apr 1, 2018

thank you for your contribution that bring improvement for Weex

@asfgit asfgit merged commit c192766 into apache:master Apr 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment