This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-270][iOS]WXListComponent should add reload type of data update #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently WXListComponent data update only supports insertRows. This can't be satisfied under some drop-down loading scenes. For example, the pulldown load needs to be positioned to the original position. When the tableView is still decaling and inserts and tries to fix the position, the cell will blink. Because when deceiring, the externally modified contentOffset will be re-edited by the internal implementation of tableView, altering contentOffset alternately will cause flicker problems. If you use the tableView reloadData this is not a problem, so you need to support the WXListComponent in the drop-down restore location scene to add the reload attribute. feat：270
Generated by 🚫 dangerJS |
…diate load of the appear WXRefreshComponent current only support the ②, shuold add new type of①. // ①refreshForAppear: load more when refresh component begin appear(if scroll is dragging or decelerating, should delay) // ②refreshForWholeVisible: load more until the whole refresh component visible NSString *_refreshType; Improvement：271
acton393
approved these changes
Apr 1, 2018
|
thank you for your contribution that bring improvement for Weex |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WXListComponent data update only supports insertRows. This can't be satisfied under some drop-down loading scenes. For example, the pulldown load needs to be positioned to the original position. When the tableView is still decelerating and inserts and tries to fix the position, the cell will blink. Because when decelerating, the externally modified contentOffset will be re-edited by the internal implementation of tableView, altering contentOffset alternately will cause flicker problems. If you use the tableView reloadData this is not a problem, so you need to support the WXListComponent in the drop-down restore location scene to add the reload attribute.
feat：270
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
CheckList:
if isBugFix :
elif isNewFeature :