New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEEX-282][iOS] update layout system to support rtl direction #1105

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
4 participants
@win80540
Contributor

win80540 commented Apr 9, 2018

Update WXComponent+layout.m to support CSS "direction:rtl".
Few languages such as Arabic, Hebrew, or Persian are written from Right to Left, but weex not support RTL layouts. To handle them. Since this PR merged, we can use weex for RTL languages.

Modified WXComponent+Layout.m:
1.set direction value to cssNode
2.setNeedLayout changed to trigger sibling component recalculate cssNode->layout

Modified WXConvert.h/m:
add convert for "direction"

Modified WXConvertTests.m:
add Tests for convert direction

Klueze
[WEEX-282][iOS] update layout system to support rtl direction
Modified WXComponent+Layout.m:
	1.set direction value to  cssNode
	2.setNeedLayout changed to trigger sibling component recalculate cssNode->layout

Modified WXConvert.h/m:
	add convert for "direction"

Modified WXConvertTests.m:
	add Tests for convert direction
@weex-bot

This comment has been minimized.

weex-bot commented Apr 9, 2018

Messages
📖 has no android file changed.
📖 android test finished.

Generated by 🚫 dangerJS

@asfgit asfgit merged commit 487b692 into apache:master Apr 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@acton393

This comment has been minimized.

Member

acton393 commented Apr 12, 2018

@win80540 thanks for you contribution

xuyouyang pushed a commit to xuyouyang/incubator-weex that referenced this pull request Apr 21, 2018

xuyouyang pushed a commit to xuyouyang/incubator-weex that referenced this pull request Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment