This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[WEEX-282][iOS] update layout system to support rtl direction #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified WXComponent+Layout.m: 1.set direction value to cssNode 2.setNeedLayout changed to trigger sibling component recalculate cssNode->layout Modified WXConvert.h/m: add convert for "direction" Modified WXConvertTests.m: add Tests for convert direction
Generated by 🚫 dangerJS |
acton393
approved these changes
Apr 12, 2018
|
@win80540 thanks for you contribution |
asfgit
pushed a commit
that referenced
this pull request
Apr 20, 2018
xuyouyang
pushed a commit
to xuyouyang/incubator-weex
that referenced
this pull request
Apr 21, 2018
xuyouyang
pushed a commit
to xuyouyang/incubator-weex
that referenced
this pull request
Apr 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update WXComponent+layout.m to support CSS "direction:rtl".
Few languages such as Arabic, Hebrew, or Persian are written from Right to Left, but weex not support RTL layouts. To handle them. Since this PR merged, we can use weex for RTL languages.
Modified WXComponent+Layout.m:
1.set direction value to cssNode
2.setNeedLayout changed to trigger sibling component recalculate cssNode->layout
Modified WXConvert.h/m:
add convert for "direction"
Modified WXConvertTests.m:
add Tests for convert direction